If computation of Stream.periodic throws, forward the error to the stream.

If computation of Stream.periodic throws, forward the error to the stream.

Fixes issue #24766
BUG= http://dartbug.com/24766
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/5009e5752444d60799fa71e77199a377b29846ce

[Lasse Reichstein Nielsen, 2015-10-30 15:42:08]

lrn@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2015-10-30 20:24:04]

Looks like something is missing, or did you only intend to change the test? (The
description sounds like a change to the Stream.periodic was intended).

[Lasse Reichstein Nielsen, 2015-10-30 23:47:12]

Ack, correct. Have now uploaded the main change as well.

[floitsch, 2015-10-31 00:10:08]

LGTM.

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
File tests/lib/async/stream_periodic6_test.dart (right):

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
tests/lib/async/stream_periodic6_test.dart:25: expect(e, 42);
maybe also check, that expected == 3.
Not necessary, though.
However, you should check, that this line is actually executed.

[Lasse Reichstein Nielsen, 2015-10-31 11:09:10]

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
File tests/lib/async/stream_periodic6_test.dart (right):

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
tests/lib/async/stream_periodic6_test.dart:25: expect(e, 42);
I think the expectAsync ensures that the function is called once.

[floitsch, 2015-10-31 19:51:30]

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
File tests/lib/async/stream_periodic6_test.dart (right):

https://codereview.chromium.org/1415533015/diff/20001/tests/lib/async/stream_...
tests/lib/async/stream_periodic6_test.dart:25: expect(e, 42);
On 2015/10/31 11:09:10, Lasse Reichstein Nielsen wrote:
> I think the expectAsync ensures that the function is called once.

Right. Missed that one...

[Lasse Reichstein Nielsen, 2015-11-04 09:28:02]

Committed patchset #2 (id:20001) manually as
5009e5752444d60799fa71e77199a377b29846ce (presubmit successful).