Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 7d499f323fed8c07245cdfd7ffcb8e76762fc3a5..cb61d4be51bc2484811f93d9cd86e300505ccdc9 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -18,6 +18,7 @@
#include "components/password_manager/core/browser/affiliation_utils.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/credentials_filter.h"
+#include "components/password_manager/core/browser/log_manager.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "components/password_manager/core/browser/password_manager_client.h"
#include "components/password_manager/core/browser/password_manager_driver.h"
@@ -312,8 +313,9 @@ void PasswordFormManager::FetchDataFromPasswordStore(
}
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (client_->GetLogManager()->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
logger->LogMessage(Logger::STRING_FETCH_LOGINS_METHOD);
logger->LogNumber(Logger::STRING_FORM_MANAGER_STATE, state_);
}
@@ -382,8 +384,9 @@ void PasswordFormManager::OnRequestDone(
const size_t logins_result_size = logins_result.size();
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (client_->GetLogManager()->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
logger->LogMessage(Logger::STRING_ON_REQUEST_DONE_METHOD);
}
@@ -585,8 +588,9 @@ void PasswordFormManager::OnGetPasswordStoreResults(
}
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (client_->GetLogManager()->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetLogManager()));
logger->LogMessage(Logger::STRING_ON_GET_STORE_RESULTS_METHOD);
logger->LogNumber(Logger::STRING_NUMBER_RESULTS, results.size());
}

Powered by Google App Engine
This is Rietveld 408576698