Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
index 1e73070a92dd10c20e3f8e5fbaf0f278850c1067..f832fb52d50afb68790bbb11f97dd524028b8d67 100644
--- a/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
+++ b/components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc
@@ -4,7 +4,7 @@
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
-#include "components/password_manager/core/browser/stub_password_manager_client.h"
+#include "components/password_manager/core/browser/stub_log_manager.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -17,13 +17,13 @@ const char kTestText[] = "test";
// The only purpose of TestLogger is to expose SendLog for the test.
class TestLogger : public BrowserSavePasswordProgressLogger {
public:
- explicit TestLogger(PasswordManagerClient* client)
- : BrowserSavePasswordProgressLogger(client) {}
+ explicit TestLogger(LogManager* log_manager)
+ : BrowserSavePasswordProgressLogger(log_manager) {}
using BrowserSavePasswordProgressLogger::SendLog;
};
-class MockPasswordManagerClient : public StubPasswordManagerClient {
+class MockLogManager : public StubLogManager {
public:
MOCK_CONST_METHOD1(LogSavePasswordProgress, void(const std::string& text));
};
@@ -31,9 +31,9 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {
} // namespace
TEST(BrowserSavePasswordProgressLoggerTest, SendLog) {
- MockPasswordManagerClient client;
- TestLogger logger(&client);
- EXPECT_CALL(client, LogSavePasswordProgress(kTestText)).Times(1);
+ MockLogManager log_manager;
+ TestLogger logger(&log_manager);
+ EXPECT_CALL(log_manager, LogSavePasswordProgress(kTestText));
logger.SendLog(kTestText);
}

Powered by Google App Engine
This is Rietveld 408576698