Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver_unittest.cc
diff --git a/components/password_manager/content/browser/content_password_manager_driver_unittest.cc b/components/password_manager/content/browser/content_password_manager_driver_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ed03eb7edd7b0a4690997d0899e0aafc24805f4c
--- /dev/null
+++ b/components/password_manager/content/browser/content_password_manager_driver_unittest.cc
@@ -0,0 +1,115 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/password_manager/content/browser/content_password_manager_driver.h"
+
+#include "components/autofill/content/common/autofill_messages.h"
+#include "components/autofill/core/browser/test_autofill_client.h"
+#include "components/password_manager/core/browser/stub_log_manager.h"
+#include "components/password_manager/core/browser/stub_password_manager_client.h"
+#include "content/public/test/mock_render_process_host.h"
+#include "content/public/test/test_renderer_host.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::Return;
+
+namespace password_manager {
+
+namespace {
+
+class MockLogManager : public StubLogManager {
+ public:
+ MOCK_CONST_METHOD0(IsLoggingActive, bool(void));
+};
+
+class MockPasswordManagerClient : public StubPasswordManagerClient {
+ public:
+ MockPasswordManagerClient() = default;
+ ~MockPasswordManagerClient() override = default;
+
+ MOCK_CONST_METHOD0(GetLogManager, const LogManager*());
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockPasswordManagerClient);
+};
+
+} // namespace
+
+class ContentPasswordManagerDriverTest
+ : public content::RenderViewHostTestHarness,
+ public testing::WithParamInterface<bool> {
+ public:
+ void SetUp() override {
+ content::RenderViewHostTestHarness::SetUp();
+ ON_CALL(password_manager_client_, GetLogManager())
+ .WillByDefault(Return(&log_manager_));
+ }
+
+ bool WasLoggingActivationMessageSent(bool* activation_flag) {
+ const uint32 kMsgID = AutofillMsg_SetLoggingState::ID;
+ const IPC::Message* message =
+ process()->sink().GetFirstMessageMatching(kMsgID);
+ if (!message)
+ return false;
+ base::Tuple<bool> param;
+ AutofillMsg_SetLoggingState::Read(message, &param);
+ *activation_flag = base::get<0>(param);
+ process()->sink().ClearMessages();
+ return true;
+ }
+
+ protected:
+ MockLogManager log_manager_;
+ MockPasswordManagerClient password_manager_client_;
+ autofill::TestAutofillClient autofill_client_;
+};
+
+TEST_P(ContentPasswordManagerDriverTest,
+ AnswerToNotificationsAboutLoggingState) {
+ const bool should_allow_logging = GetParam();
+ scoped_ptr<ContentPasswordManagerDriver> driver(
+ new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,
+ &autofill_client_));
+ process()->sink().ClearMessages();
+
+ EXPECT_CALL(log_manager_, IsLoggingActive())
+ .WillRepeatedly(Return(should_allow_logging));
+ driver->SendLoggingAvailability();
+ if (should_allow_logging) {
+ bool logging_activated = false;
+ EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
+ EXPECT_TRUE(logging_activated);
+ } else {
+ bool logging_activated = true;
+ EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
+ EXPECT_FALSE(logging_activated);
+ }
+}
+
+TEST_P(ContentPasswordManagerDriverTest, AnswerToIPCPingsAboutLoggingState) {
+ const bool should_allow_logging = GetParam();
+ scoped_ptr<ContentPasswordManagerDriver> driver(
+ new ContentPasswordManagerDriver(main_rfh(), &password_manager_client_,
+ &autofill_client_));
+
+ EXPECT_CALL(log_manager_, IsLoggingActive())
+ .WillRepeatedly(Return(should_allow_logging));
+ driver->SendLoggingAvailability();
+ process()->sink().ClearMessages();
+
+ // Ping the driver for logging activity update.
+ AutofillHostMsg_PasswordAutofillAgentConstructed msg(0);
+ driver->HandleMessage(msg);
+
+ bool logging_activated = false;
+ EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_activated));
+ EXPECT_EQ(should_allow_logging, logging_activated);
+}
+
+INSTANTIATE_TEST_CASE_P(,
+ ContentPasswordManagerDriverTest,
+ testing::Values(true, false));
+
+} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698