Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: All comments addressed Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
index b4bdb6684cbdb0d0031c632854ea47d1f2448947..abf2964c374f659ccc16ed4ba2d0cae167d1c459 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc
@@ -25,21 +25,11 @@ using ::testing::UnorderedElementsAre;
namespace {
-class MockPasswordManagerClient
- : public password_manager::StubPasswordManagerClient {
- public:
- MOCK_CONST_METHOD0(GetPasswordManager,
- const password_manager::PasswordManager*());
-};
-
class ManagePasswordsStateTest : public testing::Test {
public:
- ManagePasswordsStateTest() : password_manager_(&mock_client_) {}
+ ManagePasswordsStateTest() : password_manager_(&stub_client_) {}
void SetUp() override {
- ON_CALL(mock_client_, GetPasswordManager())
- .WillByDefault(testing::Return(&password_manager_));
-
test_local_form_.origin = GURL("http://example.com");
test_local_form_.username_value = base::ASCIIToUTF16("username");
test_local_form_.password_value = base::ASCIIToUTF16("12345");
@@ -51,7 +41,7 @@ class ManagePasswordsStateTest : public testing::Test {
test_federated_form_.origin = GURL("https://idp.com");
test_federated_form_.username_value = base::ASCIIToUTF16("username");
- passwords_data_.set_client(&mock_client_);
+ passwords_data_.set_client(&stub_client_);
}
autofill::PasswordForm& test_local_form() { return test_local_form_; }
@@ -76,7 +66,7 @@ class ManagePasswordsStateTest : public testing::Test {
void(const password_manager::CredentialInfo&));
private:
- MockPasswordManagerClient mock_client_;
+ password_manager::StubPasswordManagerClient stub_client_;
password_manager::StubPasswordManagerDriver driver_;
password_manager::PasswordManager password_manager_;
@@ -90,7 +80,7 @@ scoped_ptr<password_manager::PasswordFormManager>
ManagePasswordsStateTest::CreateFormManager() {
scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
new password_manager::PasswordFormManager(
- &password_manager_, &mock_client_, driver_.AsWeakPtr(),
+ &password_manager_, &stub_client_, driver_.AsWeakPtr(),
test_local_form(), false));
test_form_manager->SimulateFetchMatchingLoginsFromPasswordStore();
ScopedVector<autofill::PasswordForm> stored_forms;
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.cc ('k') | chrome/browser/ui/passwords/manage_passwords_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698