components/password_manager/core/browser/password_manager_unittest.cc - Issue 1415533013: Fix password manager internals renderer reporting

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_manager_driver.h ('K') | « components/password_manager/core/browser/password_manager_driver.h ('k') | components/password_manager/core/browser/stub_log_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index 6fb28b50c74ea92074b4e8265f75e375a15f5cc3..fadfcce3c95d460f09cb4a1679bd8ec65003843b 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -16,6 +16,7 @@

#include "components/password_manager/core/browser/password_manager_driver.h"

#include "components/password_manager/core/browser/password_store.h"

#include "components/password_manager/core/browser/statistics_table.h"

+#include "components/password_manager/core/browser/stub_log_manager.h"

#include "components/password_manager/core/browser/stub_password_manager_client.h"

#include "components/password_manager/core/browser/stub_password_manager_driver.h"

#include "components/password_manager/core/common/password_manager_pref_names.h"

@@ -67,6 +68,7 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {

MOCK_METHOD0(GetPrefs, PrefService*());

MOCK_METHOD0(GetDriver, PasswordManagerDriver*());

MOCK_CONST_METHOD0(GetStoreResultFilter, const CredentialsFilter*());

+ MOCK_CONST_METHOD0(GetLogManager, const LogManager*());

vasilii 2015/11/16 14:12:25 Here is an example of what you save if you update

vabr (Chromium) 2015/11/16 16:08:48 Acknowledged.

// Workaround for scoped_ptr<> lacking a copy constructor.

bool PromptUserToSaveOrUpdatePassword(

@@ -117,6 +119,7 @@ class PasswordManagerTest : public testing::Test {

EXPECT_CALL(*store_, ReportMetrics(_, _)).Times(AnyNumber());

CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));

+ ON_CALL(client_, GetLogManager()).WillByDefault(Return(&log_manager_));

EXPECT_CALL(client_, GetPasswordStore())

.WillRepeatedly(Return(store_.get()));

EXPECT_CALL(*store_, GetSiteStatsMock(_)).Times(AnyNumber());

@@ -215,6 +218,7 @@ class PasswordManagerTest : public testing::Test {

scoped_ptr<PasswordAutofillManager> password_autofill_manager_;

scoped_ptr<PasswordManager> manager_;

PasswordForm submitted_form_;

+ StubLogManager log_manager_;

};

MATCHER_P(FormMatches, form, "") {