Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix failing test Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
index 0a4fa82c4db49bf6a8846b525618ec891c992132..8d88bbcf90c810bcd0b9127f116e6724415b3c21 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
@@ -13,6 +13,7 @@
#include "components/autofill/core/common/password_form.h"
#include "components/password_manager/core/browser/password_form_manager.h"
#include "components/password_manager/core/browser/password_manager.h"
+#include "components/password_manager/core/browser/stub_log_manager.h"
#include "components/password_manager/core/browser/stub_password_manager_client.h"
#include "components/password_manager/core/browser/stub_password_manager_driver.h"
#include "components/password_manager/core/common/credential_manager_types.h"
@@ -124,8 +125,13 @@ void TestManagePasswordsUIController::NeverSavePasswordInternal() {
class MockPasswordManagerClient
: public password_manager::StubPasswordManagerClient {
public:
- MOCK_CONST_METHOD0(GetPasswordManager,
- const password_manager::PasswordManager*());
+ MockPasswordManagerClient() = default;
+ ~MockPasswordManagerClient() override = default;
+
+ MOCK_CONST_METHOD0(GetLogManager, const password_manager::LogManager*());
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(MockPasswordManagerClient);
};
} // namespace
@@ -137,8 +143,8 @@ class ManagePasswordsUIControllerTest : public ChromeRenderViewHostTestHarness {
void SetUp() override {
ChromeRenderViewHostTestHarness::SetUp();
- ON_CALL(mock_client_, GetPasswordManager())
- .WillByDefault(testing::Return(&password_manager_));
+ ON_CALL(mock_client_, GetLogManager())
+ .WillByDefault(testing::Return(&log_manager_));
// Create the test UIController here so that it's bound to
// |test_web_contents_|, and will be retrieved correctly via
@@ -198,6 +204,7 @@ class ManagePasswordsUIControllerTest : public ChromeRenderViewHostTestHarness {
MockPasswordManagerClient mock_client_;
password_manager::StubPasswordManagerDriver driver_;
password_manager::PasswordManager password_manager_;
+ password_manager::StubLogManager log_manager_;
autofill::PasswordForm test_local_form_;
autofill::PasswordForm test_federated_form_;

Powered by Google App Engine
This is Rietveld 408576698