Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate dummy log manager Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc
index 6fb28b50c74ea92074b4e8265f75e375a15f5cc3..d559e317968b05aa6b40ffcb1fbd9100c68e16a3 100644
--- a/components/password_manager/core/browser/password_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_manager_unittest.cc
@@ -11,6 +11,7 @@
#include "base/message_loop/message_loop.h"
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
+#include "components/password_manager/core/browser/dummy_log_manager.h"
#include "components/password_manager/core/browser/mock_password_store.h"
#include "components/password_manager/core/browser/password_autofill_manager.h"
#include "components/password_manager/core/browser/password_manager_driver.h"
@@ -67,6 +68,7 @@ class MockPasswordManagerClient : public StubPasswordManagerClient {
MOCK_METHOD0(GetPrefs, PrefService*());
MOCK_METHOD0(GetDriver, PasswordManagerDriver*());
MOCK_CONST_METHOD0(GetStoreResultFilter, const CredentialsFilter*());
+ MOCK_CONST_METHOD0(GetLogManager, const LogManager*());
// Workaround for scoped_ptr<> lacking a copy constructor.
bool PromptUserToSaveOrUpdatePassword(
@@ -117,6 +119,7 @@ class PasswordManagerTest : public testing::Test {
EXPECT_CALL(*store_, ReportMetrics(_, _)).Times(AnyNumber());
CHECK(store_->Init(syncer::SyncableService::StartSyncFlare()));
+ ON_CALL(client_, GetLogManager()).WillByDefault(Return(&log_manager_));
EXPECT_CALL(client_, GetPasswordStore())
.WillRepeatedly(Return(store_.get()));
EXPECT_CALL(*store_, GetSiteStatsMock(_)).Times(AnyNumber());
@@ -215,6 +218,7 @@ class PasswordManagerTest : public testing::Test {
scoped_ptr<PasswordAutofillManager> password_autofill_manager_;
scoped_ptr<PasswordManager> manager_;
PasswordForm submitted_form_;
+ DummyLogManager log_manager_;
};
MATCHER_P(FormMatches, form, "") {

Powered by Google App Engine
This is Rietveld 408576698