Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate dummy log manager Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager_client.h
diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h
index b2af53f864b69d823ff3cffe002356fcbbdaa294..6a8635275da571f9a969dfc289ec3bfda6818b62 100644
--- a/components/password_manager/core/browser/password_manager_client.h
+++ b/components/password_manager/core/browser/password_manager_client.h
@@ -20,6 +20,8 @@ class AutofillManager;
namespace password_manager {
struct CredentialInfo;
+class LogManager;
+class LogRouter;
class PasswordFormManager;
class PasswordManager;
class PasswordManagerDriver;
@@ -126,19 +128,6 @@ class PasswordManagerClient {
// TODO(vabr): Factor this out of the client to the sync layer.
virtual PasswordSyncState GetPasswordSyncState() const;
- // Only for clients which registered with a LogRouter: If called with
- // |router_can_be_used| set to false, the client may no longer use the
- // LogRouter. If |router_can_be_used| is true, the LogRouter can be used after
- // the return from OnLogRouterAvailabilityChanged.
- virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used);
-
- // Forward |text| for display to the LogRouter (if registered with one).
- virtual void LogSavePasswordProgress(const std::string& text) const;
-
- // Returns true if logs recorded via LogSavePasswordProgress will be
- // displayed, and false otherwise.
- virtual bool IsLoggingActive() const;
-
// Returns true if last navigation page had HTTP error i.e 5XX or 4XX
virtual bool WasLastNavigationHTTPError() const;
@@ -173,6 +162,14 @@ class PasswordManagerClient {
// Use this to filter credentials before handling them in password manager.
virtual const CredentialsFilter* GetStoreResultFilter() const = 0;
+ // Returns a LogManager instance.
+ virtual const LogManager* GetLogManager() const;
+
+ // Returns a LogRouter instance, unless either not available or the current
+ // tab is a WebUI (no need to log for WebUI, because passwords are never
+ // stored there).
+ virtual LogRouter* GetLogRouter() const;
vasilii 2015/11/13 12:17:31 Where is it used?
vabr (Chromium) 2015/11/13 20:48:19 Nowehere. Good catch! Removed completely.
+
private:
DISALLOW_COPY_AND_ASSIGN(PasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698