Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: components/password_manager/content/browser/content_password_manager_driver_factory.h

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate dummy log manager Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/content/browser/content_password_manager_driver_factory.h
diff --git a/components/password_manager/content/browser/content_password_manager_driver_factory.h b/components/password_manager/content/browser/content_password_manager_driver_factory.h
index b2a5daa1800c326a1ea62334cb0c8938da0d0304..3a8a6bfc607b9b46bd997bafe27c364552480b8d 100644
--- a/components/password_manager/content/browser/content_password_manager_driver_factory.h
+++ b/components/password_manager/content/browser/content_password_manager_driver_factory.h
@@ -49,6 +49,10 @@ class ContentPasswordManagerDriverFactory
content::RenderFrameHost* render_frame_host,
scoped_ptr<ContentPasswordManagerDriver> driver);
+ // Distributes |is_available| to all drivers, to notify them whether logging
+ // for chrome://password-manager-internals is available.
+ void NotifyDriversAboutLoggingAvailability(bool is_available);
+
// content::WebContentsObserver:
bool OnMessageReceived(const IPC::Message& message,
content::RenderFrameHost* render_frame_host) override;
@@ -64,7 +68,10 @@ class ContentPasswordManagerDriverFactory
PasswordManagerClient* client,
autofill::AutofillClient* autofill_client);
- void CreateDriverForFrame(content::RenderFrameHost* render_frame_host);
+ // Creates a driver for |render_frame_host|, saves it in the frame_driver_map_
+ // and returns a (non-owning) pointer to it.
+ ContentPasswordManagerDriver* CreateDriverForFrame(
+ content::RenderFrameHost* render_frame_host);
base::ScopedPtrMap<content::RenderFrameHost*,
scoped_ptr<ContentPasswordManagerDriver>>
@@ -73,6 +80,9 @@ class ContentPasswordManagerDriverFactory
PasswordManagerClient* password_client_;
autofill::AutofillClient* autofill_client_;
+ // Whether logging to chrome://password-manager-internals is available.
+ bool logging_available_ = false;
+
DISALLOW_COPY_AND_ASSIGN(ContentPasswordManagerDriverFactory);
};

Powered by Google App Engine
This is Rietveld 408576698