Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4348)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Separate dummy log manager Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index 1565545b12bc0ccbec16492710a706eacb54ed46..1a7348edd9451354d8fb01dae297f1cdafe8c02a 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -68,9 +68,6 @@ class ChromePasswordManagerClient
PrefService* GetPrefs() override;
password_manager::PasswordStore* GetPasswordStore() const override;
password_manager::PasswordSyncState GetPasswordSyncState() const override;
- void OnLogRouterAvailabilityChanged(bool router_can_be_used) override;
- void LogSavePasswordProgress(const std::string& text) const override;
- bool IsLoggingActive() const override;
bool WasLastNavigationHTTPError() const override;
bool DidLastPageLoadEncounterSSLErrors() const override;
bool IsOffTheRecord() const override;
@@ -81,6 +78,8 @@ class ChromePasswordManagerClient
const GURL& GetLastCommittedEntryURL() const override;
const password_manager::CredentialsFilter* GetStoreResultFilter()
const override;
+ const password_manager::LogManager* GetLogManager() const override;
+ password_manager::LogRouter* GetLogRouter() const override;
// Hides any visible generation UI.
void HidePasswordGenerationPopup();
@@ -92,6 +91,10 @@ class ChromePasswordManagerClient
// Observer for PasswordGenerationPopup events. Used for testing.
void SetTestObserver(autofill::PasswordGenerationPopupObserver* observer);
+ // Notifies all associated PasswordManagerDriver instances about whether
+ // logging is available.
+ void NotifyDriversAboutLoggingAvailability(bool is_available);
vasilii 2015/11/13 12:17:31 Should be private.
vabr (Chromium) 2015/11/13 20:48:18 Done.
+
// Returns true if the bubble UI is enabled, and false if we're still using
// the sad old Infobar UI.
static bool IsTheHotNewBubbleUIEnabled();
@@ -137,10 +140,6 @@ class ChromePasswordManagerClient
// for UMA stats.
void GenerationAvailableForForm(const autofill::PasswordForm& form);
- // Sends a message to the renderer with the current value of
- // |can_use_log_router_|.
- void NotifyRendererOfLoggingAvailability();
-
Profile* const profile_;
password_manager::PasswordManager password_manager_;
@@ -157,15 +156,14 @@ class ChromePasswordManagerClient
base::WeakPtr<
autofill::PasswordGenerationPopupControllerImpl> popup_controller_;
- // True if |this| is registered with some LogRouter which can accept logs.
- bool can_use_log_router_;
-
// Set to false to disable password saving (will no longer ask if you
// want to save passwords and also won't fill the passwords).
BooleanPrefMember saving_and_filling_passwords_enabled_;
const password_manager::SyncStoreResultFilter credentials_filter_;
+ scoped_ptr<password_manager::LogManager> log_manager_;
+
DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
};

Powered by Google App Engine
This is Rietveld 408576698