Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 1415533013: Fix password manager internals renderer reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 7d499f323fed8c07245cdfd7ffcb8e76762fc3a5..396bb6bfd4ccf1f6b39cfa03be7bc9ac9fb69878 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -312,8 +312,9 @@ void PasswordFormManager::FetchDataFromPasswordStore(
}
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (password_manager_->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetPasswordManager()));
vasilii 2015/11/12 16:27:34 Why not simply |password_manager_|?
vabr (Chromium) 2015/11/12 21:55:43 I apparently cannot see two lines up. :) Fixed.
logger->LogMessage(Logger::STRING_FETCH_LOGINS_METHOD);
logger->LogNumber(Logger::STRING_FORM_MANAGER_STATE, state_);
}
@@ -382,8 +383,9 @@ void PasswordFormManager::OnRequestDone(
const size_t logins_result_size = logins_result.size();
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (password_manager_->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetPasswordManager()));
logger->LogMessage(Logger::STRING_ON_REQUEST_DONE_METHOD);
}
@@ -585,8 +587,9 @@ void PasswordFormManager::OnGetPasswordStoreResults(
}
scoped_ptr<BrowserSavePasswordProgressLogger> logger;
- if (client_->IsLoggingActive()) {
- logger.reset(new BrowserSavePasswordProgressLogger(client_));
+ if (password_manager_->IsLoggingActive()) {
+ logger.reset(
+ new BrowserSavePasswordProgressLogger(client_->GetPasswordManager()));
logger->LogMessage(Logger::STRING_ON_GET_STORE_RESULTS_METHOD);
logger->LogNumber(Logger::STRING_NUMBER_RESULTS, results.size());
}

Powered by Google App Engine
This is Rietveld 408576698