 Chromium Code Reviews
 Chromium Code Reviews Issue 1415533007:
  [Android] Add sharding for AMP instrumentation tests.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 1415533007:
  [Android] Add sharding for AMP instrumentation tests.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: build/android/test_runner.py | 
| diff --git a/build/android/test_runner.py b/build/android/test_runner.py | 
| index dc683cb5d993fbd0b84a5f8279c0b9ce28dfc859..ef2e656e2c590f828cd81b71a884775304b6a8d5 100755 | 
| --- a/build/android/test_runner.py | 
| +++ b/build/android/test_runner.py | 
| @@ -126,18 +126,20 @@ def AddRemoteDeviceOptions(parser): | 
| group.add_argument('--collect', | 
| help=('Only collects the test results if set. ' | 
| 'Gets test_run_id from given file path.')) | 
| + group.add_argument('--num-shards', type=int, | 
| + help='Number of devices to shard the test across.') | 
| group.add_argument('--remote-device', action='append', | 
| help='Device type to run test on.') | 
| group.add_argument('--results-path', | 
| - help='File path to download results to.') | 
| + help='DEPRECATED File path to download results to.') | 
| 
rnephew (Reviews Here)
2015/10/26 20:42:18
So is there no way to now specify if you want to d
 
jbudorick
2015/10/26 22:23:30
Agreed. I don't think this should be deprecated.
 
mikecase (-- gone --)
2015/10/27 01:27:43
Well, now when you shard you are going to get num_
 | 
| group.add_argument('--api-protocol', | 
| help='HTTP protocol to use. (http or https)') | 
| group.add_argument('--api-address', | 
| help='Address to send HTTP requests.') | 
| group.add_argument('--api-port', | 
| help='Port to send HTTP requests to.') | 
| - group.add_argument('--runner-type', | 
| - help='Type of test to run as.') | 
| + group.add_argument('--test-framework', | 
| + help='Test framework to run test.') | 
| group.add_argument('--runner-package', | 
| help='Package name of test.') | 
| group.add_argument('--device-type', |