bluetooth: Implement requestDevice by name or name prefix

third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/bluetooth/Bluetooth.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "modules/bluetooth/BluetoothDevice.h"
 #include "modules/bluetooth/BluetoothError.h"
 #include "modules/bluetooth/BluetoothSupplement.h"
 #include "modules/bluetooth/BluetoothUUID.h"
 #include "modules/bluetooth/RequestDeviceOptions.h"
 #include "platform/UserGestureIndicator.h"
 #include "public/platform/modules/bluetooth/WebBluetooth.h"
 #include "public/platform/modules/bluetooth/WebRequestDeviceOptions.h"
 
 namespace blink {
 
-// Returns a DOMException if the conversion fails, or null if it succeeds.
+static void canonicalizeFilter(const BluetoothScanFilter& filter, WebBluetoothScanFilter& canonicalizedFilter, ExceptionState& exceptionState)
+{
+    if (!(filter.hasServices() || filter.hasName() || filter.hasNamePrefix())) {
+        exceptionState.throwTypeError(
+            "A filter must restrict the devices in some way.");
+        return;
+    }
+
+    if (filter.hasServices()) {
+        if (filter.services().size() == 0) {
+            exceptionState.throwTypeError(
+                "The services member must contain at least one service");

[scheib, 2015/10/22 04:58:42]

'services', if present, must contain ...

[ortuno, 2015/10/22 16:21:31]

Done.

+            return;
+        }
+        Vector<WebString> services;
+        for (const StringOrUnsignedLong& service : filter.services()) {
+            const String& validatedService = BluetoothUUID::getService(service, exceptionState);
+            if (exceptionState.hadException())
+                return;
+            services.append(validatedService);
+        }
+        canonicalizedFilter.services.assign(services);
+    }
+
+    if (filter.hasName()) {
+        canonicalizedFilter.name = filter.name();

[scheib, 2015/10/22 04:58:42]

Shouldn't this also test for empty string ""?

[ortuno, 2015/10/22 16:21:31]

The spec doesn't say anything about empty name. Also I don't see a reason why we
should disallow an empty name.

[scheib, 2015/10/22 18:35:52]

Hmm, I was distracted by the empty prefix. OK.

+    }
+
+    if (filter.hasNamePrefix()) {
+        if (filter.namePrefix().length() == 0) {
+            exceptionState.throwTypeError(
+                "A filter must restrict the devices in some way.");

[scheib, 2015/10/22 04:58:42]

'namePrefix', if present, must be non-empty.

[ortuno, 2015/10/22 16:21:31]

Done. This message was copied from the spec. Can you make a comment for Jeffrey
to fix?

[scheib, 2015/10/22 18:35:52]

Done.

+            return;
+        }
+        canonicalizedFilter.namePrefix = filter.namePrefix();
+    }
+}
+
 static void convertRequestDeviceOptions(const RequestDeviceOptions& options, WebRequestDeviceOptions& result, ExceptionState& exceptionState)
 {
-    if (options.hasFilters()) {
-        Vector<WebBluetoothScanFilter> filters;
-        for (const BluetoothScanFilter& filter : options.filters()) {
-            Vector<WebString> services;
-            for (const StringOrUnsignedLong& service : filter.services()) {
-                const String& validatedService = BluetoothUUID::getService(service, exceptionState);
-                if (exceptionState.hadException())
-                    return;
-                services.append(validatedService);
-            }
-            filters.append(WebBluetoothScanFilter(services));
-        }
-        result.filters.assign(filters);
+    ASSERT(options.hasFilters());
+
+    Vector<WebBluetoothScanFilter> filters;
+    for (const BluetoothScanFilter& filter : options.filters()) {
+        WebBluetoothScanFilter canonicalizedFilter = WebBluetoothScanFilter();
+
+        canonicalizeFilter(filter, canonicalizedFilter, exceptionState);
+
+        if (exceptionState.hadException())
+            return;
+
+        filters.append(canonicalizedFilter);
     }
+
+    result.filters.assign(filters);
+
     if (options.hasOptionalServices()) {
         Vector<WebString> optionalServices;
         for (const StringOrUnsignedLong& optionalService : options.optionalServices()) {
             const String& validatedOptionalService = BluetoothUUID::getService(optionalService, exceptionState);
             if (exceptionState.hadException())
                 return;
             optionalServices.append(validatedOptionalService);
         }
         result.optionalServices.assign(optionalServices);
     }
@@ skipping 25 matching lines @@
 
     // Subsequent steps are handled in the browser process.
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->requestDevice(webOptions, new CallbackPromiseAdapter<BluetoothDevice, BluetoothError>(resolver));
     return promise;
 
 }
 
 } // namespace blink