Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1415533003: VectorICs: Bugfix in KeyedStore dispatcher. (Closed)

Created:
5 years, 2 months ago by mvstanton
Modified:
5 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

VectorICs: Bugfix in KeyedStore dispatcher. The dispatcher failed to MISS properly when configured as a monomorphic keyed string store, causing a crash. BUG=v8:4495 LOG=N R=jkummerow@chromium.org Committed: https://crrev.com/2f2302f08bce6fc98b2f1c89b6014a5f78a784c5 Cr-Commit-Position: refs/heads/master@{#31362}

Patch Set 1 #

Patch Set 2 : Adding x87 port. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M src/ia32/code-stubs-ia32.cc View 5 chunks +15 lines, -9 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 5 chunks +15 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-4495.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mvstanton
Hi Jakob, I'm using "bool is_polymorphic" to separate the case where I know the feedback ...
5 years, 2 months ago (2015-10-19 08:23:57 UTC) #1
Jakob Kummerow
lgtm
5 years, 2 months ago (2015-10-19 08:56:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415533003/20001
5 years, 2 months ago (2015-10-19 09:18:03 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 09:51:29 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 09:51:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f2302f08bce6fc98b2f1c89b6014a5f78a784c5
Cr-Commit-Position: refs/heads/master@{#31362}

Powered by Google App Engine
This is Rietveld 408576698