Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141553009: Make empty traces a non-critical error (Closed)

Created:
6 years, 10 months ago by nduca
Modified:
6 years, 10 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

Make empty traces a non-critical error Its okay for a trace to come back with no data in it. Right now, this actually causes catastrophic failure. R=tonyg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247924

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -3 lines) Patch
A tools/telemetry/telemetry/core/timeline/empty_trace_importer.py View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/timeline/model.py View 1 chunk +3 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/timeline/model_unittest.py View 1 2 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
nduca
6 years, 10 months ago (2014-01-29 20:43:12 UTC) #1
dtu
Missing empty_trace_importer.py?
6 years, 10 months ago (2014-01-29 21:26:11 UTC) #2
nduca
ptal
6 years, 10 months ago (2014-01-29 22:19:43 UTC) #3
tonyg
lgtm https://codereview.chromium.org/141553009/diff/20001/tools/telemetry/telemetry/core/timeline/empty_trace_importer.py File tools/telemetry/telemetry/core/timeline/empty_trace_importer.py (right): https://codereview.chromium.org/141553009/diff/20001/tools/telemetry/telemetry/core/timeline/empty_trace_importer.py#newcode1 tools/telemetry/telemetry/core/timeline/empty_trace_importer.py:1: # Copyright (c) 2013 The Chromium Authors. All ...
6 years, 10 months ago (2014-01-29 22:48:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/141553009/40001
6 years, 10 months ago (2014-01-29 23:31:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144448
6 years, 10 months ago (2014-01-30 00:47:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nduca@chromium.org/141553009/40001
6 years, 10 months ago (2014-01-30 09:12:41 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 10:33:47 UTC) #8
Message was sent while issue was closed. 
Change committed as 247924

Powered by Google App Engine
This is Rietveld 408576698