Update InspectorBackend.TakeJSHeapSnapshot to make it work with the new HeapProfiler behavior

Update InspectorBackend.TakeJSHeapSnapshot to make it work with the new HeapProfiler behavior

HeapProfiler.getHeapSnapshot command is being removed from the protocol. Heap snapshot is now sent in response to HeapProfiler.takeHeapSnapshot command.

BUG=324769
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248161

[yurys, 2014-01-29 15:34:28]

marja@ : please take a look.

[alph, 2014-01-29 15:37:24]

lgtm

[marja, 2014-01-29 15:44:06]

lgtm

[tonyg, 2014-01-29 15:49:01]

We aim for Telemetry to be backwards compatible back to the current stable
channel version. Will this change work with the stable channel?

[marja, 2014-01-29 15:54:11]

On 2014/01/29 15:49:01, tonyg wrote:
> We aim for Telemetry to be backwards compatible back to the current stable
> channel version. Will this change work with the stable channel?

It doesn't, but this function is not used by anything in the Chromium repo atm.

However, it's possible to implement this in a backwards-compatible way
(described here: https://codereview.chromium.org/98273008/ ), if you'd prefer
that.

[yurys, 2014-01-29 17:34:26]

@tonyg: this change will break backward compatibility with the previous
versions. But as Marja pointed out this function is not used atm and if possible
I'd prefer to switch to the new protocol and drop support for the old one, this
would keep the code clear.

[commit-bot: I haz the power, 2014-01-31 06:36:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/141553008/1

[commit-bot: I haz the power, 2014-01-31 08:06:08]

Retried try job too often on win_rel for step(s) telemetry_perf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-31 08:06:18]

CQ bit was unchecked on CL. Ignoring.

[commit-bot: I haz the power, 2014-01-31 09:05:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yurys@chromium.org/141553008/1

[commit-bot: I haz the power, 2014-01-31 10:19:40]

Change committed as 248161

[commit-bot: I haz the power, 2014-01-31 10:19:49]

CQ bit was unchecked on CL. Ignoring.