Make ZoneObject::operator delete not public.

src/zone.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 125 matching lines @@
 };
 
 
 // ZoneObject is an abstraction that helps define classes of objects
 // allocated in the Zone. Use it as a base class; see ast.h.
 class ZoneObject {
  public:
   // Allocate a new ZoneObject of 'size' bytes in the Zone.
   INLINE(void* operator new(size_t size, Zone* zone));
 
   // Ideally, the delete operator should be private instead of

[tfarina, 2014/01/29 17:39:15]

can you update this comment while you are here?

[marja, 2014/01/29 17:42:18]

Actually... I should've read the "MSVC requires the delete operator to be
public" part. It makes this CL pointless. Nevermind. Closing. Thanks for
pointing out the comment.

[tfarina, 2014/01/29 17:45:00]

So disregards my latest comment in src/zone.h:236 ;-)

   // public, but unfortunately the compiler sometimes synthesizes
   // (unused) destructors for classes derived from ZoneObject, which
   // require the operator to be visible. MSVC requires the delete
   // operator to be public.
 
   // ZoneObjects should never be deleted individually; use
   // Zone::DeleteAll() to delete all zone objects in one go.
+ protected:
   void operator delete(void*, size_t) { UNREACHABLE(); }
   void operator delete(void* pointer, Zone* zone) { UNREACHABLE(); }
 };
 
 
 // The ZoneScope is used to automatically call DeleteAll() on a
 // Zone when the ZoneScope is destroyed (i.e. goes out of scope)
 struct ZoneScope {
  public:
   explicit ZoneScope(Zone* zone) : zone_(zone) { }
@@ skipping 61 matching lines @@
                                                    ZoneAllocationPolicy(zone));
   }
   INLINE(void Allocate(int length, Zone* zone)) {
     List<T, ZoneAllocationPolicy>::Allocate(length, ZoneAllocationPolicy(zone));
   }
   INLINE(void Initialize(int capacity, Zone* zone)) {
     List<T, ZoneAllocationPolicy>::Initialize(capacity,
                                               ZoneAllocationPolicy(zone));
   }
 
   void operator delete(void* pointer) { UNREACHABLE(); }

[tfarina, 2014/01/29 17:43:43]

do you want to make these and the ZoneSplayTree ones protected as well?

   void operator delete(void* pointer, Zone* zone) { UNREACHABLE(); }
 };
 
 
 // A zone splay tree.  The config type parameter encapsulates the
 // different configurations of a concrete splay tree (see splay-tree.h).
 // The tree itself and all its elements are allocated in the Zone.
 template <typename Config>
 class ZoneSplayTree: public SplayTree<Config, ZoneAllocationPolicy> {
  public:
   explicit ZoneSplayTree(Zone* zone)
       : SplayTree<Config, ZoneAllocationPolicy>(ZoneAllocationPolicy(zone)) {}
   ~ZoneSplayTree();
 
   INLINE(void* operator new(size_t size, Zone* zone));
 
   void operator delete(void* pointer) { UNREACHABLE(); }
   void operator delete(void* pointer, Zone* zone) { UNREACHABLE(); }
 };
 
 
 typedef TemplateHashMapImpl<ZoneAllocationPolicy> ZoneHashMap;
 
 } }  // namespace v8::internal
 
 #endif  // V8_ZONE_H_