Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1450)

Issue 141553006: Revert of Add the viewer toolbar to the PDF extension (Closed)

Created:
6 years, 10 months ago by haitaol1
Modified:
6 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Revert of Add the viewer toolbar to the PDF extension (https://codereview.chromium.org/110723007/) Reason for revert: License check failure: http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/51195 Original issue's description: > Add the viewer toolbar to the PDF extension. > > BUG=303491 > R=arv@chromium.org, ganetsky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247578 TBR=ganetsky@chromium.org,arv@chromium.org,raymes@chromium.org NOTREECHECKS=true NOTRY=true BUG=303491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -798 lines) Patch
M chrome/browser/resources/component_extension_resources.grd View 1 chunk +1 line, -15 lines 0 comments Download
M chrome/browser/resources/pdf/background.js View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/resources/pdf/index.html View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/resources/pdf/index.js View 1 chunk +0 lines, -451 lines 0 comments Download
D chrome/browser/resources/pdf/index.in.html View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/resources/pdf/polymer_loader.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haitaol1
Created Revert of Add the viewer toolbar to the PDF extension
6 years, 10 months ago (2014-01-29 02:06:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haitaol@chromium.org/141553006/1
6 years, 10 months ago (2014-01-29 02:09:05 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/component_extension_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-01-29 02:09:09 UTC) #3
raymes
6 years, 10 months ago (2014-01-29 02:09:20 UTC) #4
On 2014/01/29 02:06:51, haitaol1 wrote:
> Created Revert of Add the viewer toolbar to the PDF extension

reverted in r247588.

Powered by Google App Engine
This is Rietveld 408576698