Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1415513008: Local modifications of golang source: Sort the keys of a map when printing them. (Closed)

Created:
5 years, 1 month ago by rudominer
Modified:
5 years, 1 month ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Local modifications of golang source: Sort the keys of a map when printing them. R=azani@chromium.org, azani BUG=#461 When printing a map using reflection, sort the keys of the map if they are of numeric or string type. This helps make the deep-printing a Go structures more deterministic and therefore more useful in tests. Committed: https://chromium.googlesource.com/external/mojo/+/4cb142bcbe768ca086b44d9acb1e15650fca7f5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -3 lines) Patch
M third_party/golang/README View 1 chunk +6 lines, -3 lines 0 comments Download
M third_party/golang/src/fmt/print.go View 3 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rudominer
Hi Alex, ptal.
5 years, 1 month ago (2015-11-05 16:00:52 UTC) #4
azani
lgtm
5 years, 1 month ago (2015-11-05 17:41:38 UTC) #5
rudominer
5 years, 1 month ago (2015-11-05 18:31:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
4cb142bcbe768ca086b44d9acb1e15650fca7f5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698