Issue 1415513004: Merge to XFA: Remove unused CFFL_Notify.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415513004: Merge to XFA: Remove unused CFFL_Notify. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Remove unused CFFL_Notify. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411963002 . (cherry picked from commit 8b8dfd7934d669b2c74a0502f82387e5df0f573b) Committed: https://pdfium.googlesource.com/pdfium/+/dd11f8615fc20e638fbb6f6281c4564ed8927af3

Patch Set 1 #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -257 lines)			Patch
M	BUILD.gn	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	fpdfsdk/include/formfiller/FFL_Notify.h	View	1 chunk	+0 lines, -75 lines	1 comment	Download
M	fpdfsdk/src/formfiller/FFL_FormFiller.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	fpdfsdk/src/formfiller/FFL_Notify.cpp	View	1 chunk	+0 lines, -177 lines	0 comments	Download
M	pdfium.gyp	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR, conflicted, but the conflict is irrelevant. https://codereview.chromium.org/1415513004/diff/1/fpdfsdk/include/formfiller/FFL_Notify.h File fpdfsdk/include/formfiller/FFL_Notify.h (left): https://codereview.chromium.org/1415513004/diff/1/fpdfsdk/include/formfiller/FFL_Notify.h#oldcode70 fpdfsdk/include/formfiller/FFL_Notify.h:70: CFFL_FormFiller* m_pFormFiller; ...

5 years, 2 months ago (2015-10-20 00:30:18 UTC) #1

Lei Zhang

Committed patchset #1 (id:1) manually as dd11f8615fc20e638fbb6f6281c4564ed8927af3 (presubmit successful).

5 years, 2 months ago (2015-10-20 00:30:28 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages