third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html - Issue 1415513002: Remove plumbing for inert-visual-viewport flag

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-fling-with-page-scale.html

Issue 1415513002: Remove plumbing for inert-visual-viewport flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Keeping "inertVisualViewport" setting + fixed broken test Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/scroll-in-scaled-page-with-overflow-hidden-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/history/scroll-restoration/scroll-restoration-scale-not-impacted.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2	2

3 <script src="../../../../resources/js-test.js"></script>	3 <script src="../../../../resources/js-test.js"></script>

4 <script>	4 <script>

5 if (window.testRunner && window.eventSender && window.internals) {	5 if (window.testRunner && window.eventSender && window.internals) {

6 window.jsTestIsAsync = true;	6 window.jsTestIsAsync = true;

7 testRunner.waitUntilDone();	7 testRunner.waitUntilDone();

8 }	8 }

9	9

10 var horizontalContainer;	10 var horizontalContainer;

(...skipping 66 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
77 }	77 }

78	78

79 var setVerticalContainerScrollsExpectation = function() {	79 var setVerticalContainerScrollsExpectation = function() {

80 verticalContainer.addEventListener("scroll", verticalContainerScrollHandler) ;	80 verticalContainer.addEventListener("scroll", verticalContainerScrollHandler) ;

81 checkExpectation = function() {	81 checkExpectation = function() {

82 shouldNotBe('verticalContainer.scrollTop', 'fullyScrolled');	82 shouldNotBe('verticalContainer.scrollTop', 'fullyScrolled');

83 }	83 }

84 }	84 }

85	85

86 var setContainerDoesntScrollExpectation = function() {	86 var setContainerDoesntScrollExpectation = function() {

	87 // Scrolling just the visual viewport doesn't trigger scroll events. Thus,

	88 // we scroll the layout viewport before the fling so that the fling triggers

	89 // the scrollHandler.

	90 window.scrollTo(10, 10);
	bokan 2015/10/21 21:48:36 I'm a bit worried that this could cause flakiness I'm a bit worried that this could cause flakiness if we fire the scroll handler before the scroll reaches one of the container boxes. Could you instead scroll the window in reset() and adjust the startX/Y position (or if you scroll to (1, 1) you probably don't even have to adjust the startX/Y) so that when the container boxes finish scrolling, they'll bubble up and cause a scroll on the window?
87 window.addEventListener("scroll", scrollHandler);	91 window.addEventListener("scroll", scrollHandler);

88 checkExpectation = function() {	92 checkExpectation = function() {

89 shouldBe('verticalContainer.scrollTop', 'fullyScrolled');	93 shouldBe('verticalContainer.scrollTop', 'fullyScrolled');

90 shouldBe('horizontalContainer.scrollLeft', 'fullyScrolled');	94 shouldBe('horizontalContainer.scrollLeft', 'fullyScrolled');

91 }	95 }

92 }	96 }

93	97

94 var reset = function() {	98 var reset = function() {

95 window.removeEventListener("scroll", scrollHandler);	99 window.removeEventListener("scroll", scrollHandler);

96 horizontalContainer.removeEventListener("scroll", horizontalContainerScrollH andler);	100 horizontalContainer.removeEventListener("scroll", horizontalContainerScrollH andler);

(...skipping 84 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
181 }	185 }

182 }	186 }

183	187

184 var runTest = function() {	188 var runTest = function() {

185 reset();	189 reset();

186 tests[currentTest]();	190 tests[currentTest]();

187 }	191 }

188 </script>	192 </script>

189	193

190 <style>	194 <style>

	195 body {

	196 width: 1000px;

	197 height: 1000px;

	198 }

191 .verticalContainer {	199 .verticalContainer {

192 position: absolute;	200 position: absolute;

193 left: 350px;	201 left: 350px;

194 top: 0px;	202 top: 0px;

195 width: 50px;	203 width: 50px;

196 height: 300px;	204 height: 300px;

197 overflow-y: scroll;	205 overflow-y: scroll;

198 overflow-x: hidden;	206 overflow-x: hidden;

199 }	207 }

200	208

(...skipping 64 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
265 <div style="float: left" class="greenbox"></div>	273 <div style="float: left" class="greenbox"></div>

266 <div style="float: left" class="redbox"></div>	274 <div style="float: left" class="redbox"></div>

267 <div style="float: left" class="greenbox"></div>	275 <div style="float: left" class="greenbox"></div>

268 <div style="float: left" class="redbox"></div>	276 <div style="float: left" class="redbox"></div>

269 <div style="float: left" class="greenbox"></div>	277 <div style="float: left" class="greenbox"></div>

270 <div style="float: left" class="redbox"></div>	278 <div style="float: left" class="redbox"></div>

271 <div style="float: left" class="greenbox"></div>	279 <div style="float: left" class="greenbox"></div>

272 <div style="float: left" class="redbox"></div>	280 <div style="float: left" class="redbox"></div>

273 </div>	281 </div>

274 </div>	282 </div>

OLD	NEW