third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html - Issue 1415513002: Remove plumbing for inert-visual-viewport flag

Side by Side Diff: third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event.html

Issue 1415513002: Remove plumbing for inert-visual-viewport flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worked on review comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/dom/Window/window-scaled-viewport-properties.html ('K') | « third_party/WebKit/LayoutTests/fast/scroll-behavior/main-frame-pinch-scrolls-layout-viewport-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/scroll-behavior/visual-viewport-scroll-no-onscroll-event-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/js-test.js"></script>

	3 <style>

	4 #target {

	5 width: 2000px;

	6 height: 1500px;

	7 }

	8 </style>

	9 <script language="JavaScript" type="text/javascript">

	10 if (window.testRunner && window.internals) {

	11 window.jsTestIsAsync = true;

	12 testRunner.dumpAsText();

	13 testRunner.waitUntilDone();

	14 setPrintTestResultsLazily();

	15 }

	16

	17 description("This test ensures that scrolling the visual viewport doesn't\

	18 trigger an onscroll event.");

	19

	20 function runTest() {

	21 if (!window.testRunner \|\| !window.internals) {

	22 testFailed("This test requires test runner and internals")

	23 finishJSTest();

	24 return;

	25 }

	26

	27 window.internals.setPageScaleFactor(2.0);

	28 var target = document.getElementById('target');

	29

	30 var numScrollsReceived = 0;

	31 var numRAFCalls = 0;

	32

	33 document.onscroll = function() {

	34 if (numRAFCalls == 0)
	bokan 2015/10/21 15:23:06 You can remove this too now. You can remove this too now. ymalik 2015/10/21 16:29:28 Done. Show quoted text On 2015/10/21 15:23:06, bokan wrote: > You can remove this too now. Done.
	35 return;

	36 ++numScrollsReceived;

	37 debug('OnScroll called for scroll #' + numScrollsReceived);

	38 }

	39

	40 var failureSentinel = function() {

	41 if (numRAFCalls == 0) {

	42 // The first scroll should trigger onscroll because it scrolls

	43 // the layout viewport.

	44 eventSender.mouseMoveTo(target.offsetLeft + 5, target.offsetTop + 5);

	45 eventSender.mouseScrollBy(0, -10);

	46 } else if (numRAFCalls == 1) {

	47 if (numScrollsReceived < numRAFCalls) {
	bokan 2015/10/21 15:23:06 We know there should be exactly one scroll here, I We know there should be exactly one scroll here, I'd just replace this with shouldBe('numScrollsReceived', '1') ymalik 2015/10/21 16:29:27 Done. Show quoted text On 2015/10/21 15:23:06, bokan wrote: > We know there should be exactly one scroll here, I'd just replace this with > shouldBe('numScrollsReceived', '1') Done.
	48 testFailed("Did not receive scroll event #" + (numScrollsRec eived+1));

	49 finishJSTest();

	50 return;

	51 }

	52 // The second scroll should not trigger onscroll because it only

	53 // scrolls the visual viewport.

	54 eventSender.mouseMoveTo(target.offsetLeft + 5, target.offsetTop + 5);

	55 eventSender.mouseScrollBy(0, 1);

	56 } else {

	57 if (numScrollsReceived >= numRAFCalls) {
	bokan 2015/10/21 15:23:06 Ditto here. Ditto here. ymalik 2015/10/21 16:29:27 Done. Show quoted text On 2015/10/21 15:23:06, bokan wrote: > Ditto here. Done.
	58 testFailed("Received unexpected scroll event #" + numScrolls Received);

	59 finishJSTest();

	60 return;

	61 }

	62 finishJSTest();

	63 }

	64 ++numRAFCalls;

	65 window.requestAnimationFrame(failureSentinel);

	66 }

	67

	68 window.requestAnimationFrame(failureSentinel);

	69 }

	70

	71 onload = runTest;

	72 </script>

	73 <div id="target"></div>

OLD	NEW