Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: src/gpu/gl/GrGLInterface.cpp

Issue 1415503008: Fix setColocatedSampleLocations on ES and GL < 4.5 (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/gpu/gl/GrGLGpu.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 Google Inc. 2 * Copyright 2011 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 8
9 #include "gl/GrGLInterface.h" 9 #include "gl/GrGLInterface.h"
10 #include "gl/GrGLExtensions.h" 10 #include "gl/GrGLExtensions.h"
(...skipping 695 matching lines...) Expand 10 before | Expand all | Expand 10 after
706 nullptr == fFunctions.fGetVertexArrayPointerv || 706 nullptr == fFunctions.fGetVertexArrayPointerv ||
707 nullptr == fFunctions.fGetVertexArrayIntegeri_v || 707 nullptr == fFunctions.fGetVertexArrayIntegeri_v ||
708 nullptr == fFunctions.fGetVertexArrayPointeri_v || 708 nullptr == fFunctions.fGetVertexArrayPointeri_v ||
709 nullptr == fFunctions.fMapNamedBufferRange || 709 nullptr == fFunctions.fMapNamedBufferRange ||
710 nullptr == fFunctions.fFlushMappedNamedBufferRange) { 710 nullptr == fFunctions.fFlushMappedNamedBufferRange) {
711 RETURN_FALSE_INTERFACE 711 RETURN_FALSE_INTERFACE
712 } 712 }
713 } 713 }
714 } 714 }
715 715
716 if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
717 (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1))) {
718 if (nullptr == fFunctions.fFramebufferParameteri) {
719 RETURN_FALSE_INTERFACE
720 }
721 }
722
716 if (kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,5)) { 723 if (kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,5)) {
717 if (nullptr == fFunctions.fNamedFramebufferParameteri) { 724 if (nullptr == fFunctions.fNamedFramebufferParameteri) {
718 RETURN_FALSE_INTERFACE 725 RETURN_FALSE_INTERFACE
719 } 726 }
720 } 727 }
721 728
722 if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) || 729 if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
723 fExtensions.has("GL_KHR_debug")) { 730 fExtensions.has("GL_KHR_debug")) {
724 if (nullptr == fFunctions.fDebugMessageControl || 731 if (nullptr == fFunctions.fDebugMessageControl ||
725 nullptr == fFunctions.fDebugMessageInsert || 732 nullptr == fFunctions.fDebugMessageInsert ||
726 nullptr == fFunctions.fDebugMessageCallback || 733 nullptr == fFunctions.fDebugMessageCallback ||
727 nullptr == fFunctions.fGetDebugMessageLog || 734 nullptr == fFunctions.fGetDebugMessageLog ||
728 nullptr == fFunctions.fPushDebugGroup || 735 nullptr == fFunctions.fPushDebugGroup ||
729 nullptr == fFunctions.fPopDebugGroup || 736 nullptr == fFunctions.fPopDebugGroup ||
730 nullptr == fFunctions.fObjectLabel) { 737 nullptr == fFunctions.fObjectLabel) {
731 RETURN_FALSE_INTERFACE 738 RETURN_FALSE_INTERFACE
732 } 739 }
733 } 740 }
734 741
735 return true; 742 return true;
736 } 743 }
OLDNEW
« no previous file with comments | « src/gpu/gl/GrGLGpu.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698