Fix setColocatedSampleLocations on ES and GL < 4.5

src/gpu/gl/GrGLInterface.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "gl/GrGLInterface.h"
 #include "gl/GrGLExtensions.h"
@@ skipping 695 matching lines @@
                 nullptr == fFunctions.fGetVertexArrayPointerv ||
                 nullptr == fFunctions.fGetVertexArrayIntegeri_v ||
                 nullptr == fFunctions.fGetVertexArrayPointeri_v ||
                 nullptr == fFunctions.fMapNamedBufferRange ||
                 nullptr == fFunctions.fFlushMappedNamedBufferRange) {
                 RETURN_FALSE_INTERFACE
             }
         }
     }
 
+    if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
+        (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1)) ||
+        fExtensions.has("GL_NV_sample_locations") ||

[bsalomon, 2015/11/03 15:21:12]

Here you check for the extensions but not in the interface assembler code?

[Chris Dalton, 2015/11/03 15:49:15]

Yeah this check was a little OCD. glFramebufferParameteri is core, but the idea
was that these extensions depend on it (they're written against OpenGL versions
that have this function). I can just take the check out for the extensions.

[bsalomon, 2015/11/03 15:54:22]

I suppose if a vendor shipped an ES 3.0 with the extension advertised then we'd
expect to be able to get the function. So maybe update the assembler code? I
don't really have a strong opinion though, so happy to go with whatever you
think is best.

+        fExtensions.has("GL_ARB_sample_locations")) {
+        if (nullptr == fFunctions.fFramebufferParameteri) {
+            RETURN_FALSE_INTERFACE
+        }
+    }
+
     if (kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,5)) {
         if (nullptr == fFunctions.fNamedFramebufferParameteri) {
             RETURN_FALSE_INTERFACE
         }
     }
 
     if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
         fExtensions.has("GL_KHR_debug")) {
         if (nullptr == fFunctions.fDebugMessageControl ||
             nullptr == fFunctions.fDebugMessageInsert ||
             nullptr == fFunctions.fDebugMessageCallback ||
             nullptr == fFunctions.fGetDebugMessageLog ||
             nullptr == fFunctions.fPushDebugGroup ||
             nullptr == fFunctions.fPopDebugGroup ||
             nullptr == fFunctions.fObjectLabel) {
             RETURN_FALSE_INTERFACE
         }
     }
 
     return true;
 }