Fix setColocatedSampleLocations on ES and GL < 4.5

src/gpu/gl/GrGLGpu.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "GrGLGpu.h"
 #include "GrGLGLSL.h"
@@ skipping 2017 matching lines @@
 
 void GrGLGpu::setColocatedSampleLocations(GrRenderTarget* rt, bool useColocatedSampleLocations) {
     GrGLRenderTarget* target = static_cast<GrGLRenderTarget*>(rt->asRenderTarget());
     SkASSERT(0 != target->renderFBOID());
 
     if (!rt->isStencilBufferMultisampled() ||
         useColocatedSampleLocations == target->usesColocatedSampleLocations()) {
         return;
     }
 
-    GL_CALL(NamedFramebufferParameteri(target->renderFBOID(),
-                                       GR_GL_FRAMEBUFFER_PROGRAMMABLE_SAMPLE_LOCATIONS,
-                                       useColocatedSampleLocations));
+    if (kGL_GrGLStandard == this->glStandard() && this->glVersion() >= GR_GL_VER(4,5)) {

[Chris Dalton, 2015/11/03 07:21:30]

Would it be ok/consistent/better to just check the function ptr itself for being
null? Then it's one check instead of two.

[bsalomon, 2015/11/03 15:21:12]

In general we don't do that. You could add a enum to GrGLCaps that indicates
which function to use.

[Chris Dalton, 2015/11/03 15:49:15]

No problem. Would you actually prefer another cap? Or are we fine just checking
the GL version?

[bsalomon, 2015/11/03 15:54:22]

Whatever works for you

+        GL_CALL(NamedFramebufferParameteri(target->renderFBOID(),
+                                           GR_GL_FRAMEBUFFER_PROGRAMMABLE_SAMPLE_LOCATIONS,
+                                           useColocatedSampleLocations));
+    } else {
+        GL_CALL(BindFramebuffer(GR_GL_FRAMEBUFFER, target->renderFBOID()));
+        GL_CALL(FramebufferParameteri(GR_GL_FRAMEBUFFER,
+                                      GR_GL_FRAMEBUFFER_PROGRAMMABLE_SAMPLE_LOCATIONS,
+                                      useColocatedSampleLocations));
+        fHWBoundRenderTargetUniqueID = SK_InvalidUniqueID;
+    }
 
     target->flagAsUsingColocatedSampleLocations(useColocatedSampleLocations);
 }
 
 void GrGLGpu::flushRenderTarget(GrGLRenderTarget* target, const SkIRect* bound) {
 
     SkASSERT(target);
 
     uint32_t rtID = target->getUniqueID();
     if (fHWBoundRenderTargetUniqueID != rtID) {
@@ skipping 1260 matching lines @@
             this->setVertexArrayID(gpu, 0);
         }
         int attrCount = gpu->glCaps().maxVertexAttributes();
         if (fDefaultVertexArrayAttribState.count() != attrCount) {
             fDefaultVertexArrayAttribState.resize(attrCount);
         }
         attribState = &fDefaultVertexArrayAttribState;
     }
     return attribState;
 }