Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1415503007: Remove [TreatNullAs=NullString] from title attribute on Document (Closed)

Created:
5 years, 1 month ago by tanay.c
Modified:
5 years, 1 month ago
Reviewers:
philipj_slow
CC:
Habib Virji
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove [TreatNullAs=NullString] from title attribute on Document Current behavior: Chrome: document.title=null => "" Edge: document.title=null => "null" Firefox Nightly: document.title=null => "null" After this change, we will align with Edge and Firefox. BUG=497307 Committed: https://crrev.com/e7eb96b6d15fe9e29b4723e72352bfd457d23697 Cr-Commit-Position: refs/heads/master@{#356838}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null.html View 1 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/document-attribute-js-null-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
tanay.c
PTAL
5 years, 1 month ago (2015-10-27 09:20:32 UTC) #2
philipj_slow
The document.cookie change was submitted once before, see my comment on https://codereview.chromium.org/1157223007/ Similarly for the ...
5 years, 1 month ago (2015-10-27 09:24:02 UTC) #3
tanay.c
On 2015/10/27 09:24:02, philipj wrote: > The document.cookie change was submitted once before, see my ...
5 years, 1 month ago (2015-10-27 11:37:06 UTC) #4
philipj_slow
OK, sounds like for title and dir all you'd need to do is to update ...
5 years, 1 month ago (2015-10-27 13:12:28 UTC) #5
tanay.c
On 2015/10/27 13:12:28, philipj wrote: > OK, sounds like for title and dir all you'd ...
5 years, 1 month ago (2015-10-28 10:48:32 UTC) #7
philipj_slow
On 2015/10/28 10:48:32, tanay.c wrote: > On 2015/10/27 13:12:28, philipj wrote: > > OK, sounds ...
5 years, 1 month ago (2015-10-28 12:02:42 UTC) #9
philipj_slow
lgtm
5 years, 1 month ago (2015-10-28 12:02:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415503007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415503007/20001
5 years, 1 month ago (2015-10-28 12:03:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415503007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415503007/20001
5 years, 1 month ago (2015-10-29 11:57:29 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-29 14:37:41 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 14:38:39 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7eb96b6d15fe9e29b4723e72352bfd457d23697
Cr-Commit-Position: refs/heads/master@{#356838}

Powered by Google App Engine
This is Rietveld 408576698