Issue 1415503006: add work item info to context status page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415503006: add work item info to context status page (Closed)

Created:
5 years, 2 months ago by keertip

Modified:
5 years, 2 months ago

Reviewers:
pquitslund, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add work item info to context status page BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/c133bf9467a2b469c24bf77e6187d727b4ef2595

Patch Set 1 #

Patch Set 2 : fix whitespace #

Total comments: 1

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	pkg/analysis_server/lib/src/status/get_handler.dart	View	1	3 chunks	+14 lines, -1 line	0 comments	Download
	M	pkg/analyzer/lib/src/task/driver.dart	View		1 chunk	+2 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

keertip

Committed patchset #2 (id:20001) manually as c133bf9467a2b469c24bf77e6187d727b4ef2595 (presubmit successful).

5 years, 2 months ago (2015-10-23 20:27:20 UTC) #4

pquitslund

5 years, 2 months ago (2015-10-23 20:33:28 UTC) #5

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/1415503006/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/driver.dart (right):

https://codereview.chromium.org/1415503006/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/driver.dart:740: List<WorkItem> get workItems =>
_dependencyWalker._path;
Maybe a doc here?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages