Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 1415493008: ASSERTION FAILED: !m_overflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nittified! Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutListItem.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
index fc73d5a54cd898bcc8eb27d31b33ca5800f9e5fa..b644a123c117ae9ab0e0978012d17a2e1ba2db78 100644
--- a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp
@@ -350,6 +350,8 @@ void LayoutListItem::positionListMarker()
LayoutUnit lineTop = root.lineTop();
LayoutUnit lineBottom = root.lineBottom();
+ // TODO(jchaffraix): Propagating the overflow to the line boxes seems
+ // pretty wrong (https://crbug.com/554160).
// FIXME: Need to account for relative positioning in the layout overflow.
if (style()->isLeftToRightDirection()) {
LayoutUnit leftLineOffset = logicalLeftOffsetForLine(blockOffset, logicalLeftOffsetForLine(blockOffset, false), false);
@@ -370,7 +372,7 @@ void LayoutListItem::positionListMarker()
if (box == root)
adjustOverflow = true;
}
- box->setOverflowFromLogicalRects(newLogicalLayoutOverflowRect, newLogicalVisualOverflowRect, lineTop, lineBottom);
+ box->overrideOverflowFromLogicalRects(newLogicalLayoutOverflowRect, newLogicalVisualOverflowRect, lineTop, lineBottom);
if (box->boxModelObject().hasSelfPaintingLayer())
hitSelfPaintingLayer = true;
}
@@ -391,7 +393,7 @@ void LayoutListItem::positionListMarker()
if (box == root)
adjustOverflow = true;
}
- box->setOverflowFromLogicalRects(newLogicalLayoutOverflowRect, newLogicalVisualOverflowRect, lineTop, lineBottom);
+ box->overrideOverflowFromLogicalRects(newLogicalLayoutOverflowRect, newLogicalVisualOverflowRect, lineTop, lineBottom);
if (box->boxModelObject().hasSelfPaintingLayer())
hitSelfPaintingLayer = true;

Powered by Google App Engine
This is Rietveld 408576698