Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Side by Side Diff: third_party/WebKit/Source/core/layout/line/InlineBox.h

Issue 1415493008: ASSERTION FAILED: !m_overflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated comment after discussion with Levi! Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved. 2 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All r ights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
344 void setBidiEmbeddingLevel(unsigned char bidiEmbeddingLevel) { m_bidiEmb eddingLevel = bidiEmbeddingLevel; } 344 void setBidiEmbeddingLevel(unsigned char bidiEmbeddingLevel) { m_bidiEmb eddingLevel = bidiEmbeddingLevel; }
345 345
346 ADD_BOOLEAN_BITFIELD(dirty, Dirty); 346 ADD_BOOLEAN_BITFIELD(dirty, Dirty);
347 ADD_BOOLEAN_BITFIELD(extracted, Extracted); 347 ADD_BOOLEAN_BITFIELD(extracted, Extracted);
348 ADD_BOOLEAN_BITFIELD(hasVirtualLogicalHeight, HasVirtualLogicalHeight); 348 ADD_BOOLEAN_BITFIELD(hasVirtualLogicalHeight, HasVirtualLogicalHeight);
349 ADD_BOOLEAN_BITFIELD(isHorizontal, IsHorizontal); 349 ADD_BOOLEAN_BITFIELD(isHorizontal, IsHorizontal);
350 // for RootInlineBox 350 // for RootInlineBox
351 ADD_BOOLEAN_BITFIELD(endsWithBreak, EndsWithBreak); // Whether the line ends with a <br>. 351 ADD_BOOLEAN_BITFIELD(endsWithBreak, EndsWithBreak); // Whether the line ends with a <br>.
352 // shared between RootInlineBox and InlineTextBox 352 // shared between RootInlineBox and InlineTextBox
353 ADD_BOOLEAN_BITFIELD(hasSelectedChildrenOrCanHaveLeadingExpansion, HasSe lectedChildrenOrCanHaveLeadingExpansion); 353 ADD_BOOLEAN_BITFIELD(hasSelectedChildrenOrCanHaveLeadingExpansion, HasSe lectedChildrenOrCanHaveLeadingExpansion);
354
355 // This boolean tracks whether we know that this box has no overflow.
leviw_travelin_and_unemployed 2015/11/13 00:40:33 Nit: I wouldn't even bother with this first line n
Julien - ping for review 2015/11/13 02:08:26 Fair, removed.
356 //
357 // This boolean will never be set if there is potential for overflow,
358 // but it will be eagerly cleared in the opposite case. As such, it's
359 // a conservative tracking of the absence of overflow.
360 //
361 // For whether we have overflow, callers should use m_overflow on
362 // InlineFlowBox.
354 ADD_BOOLEAN_BITFIELD(knownToHaveNoOverflow, KnownToHaveNoOverflow); 363 ADD_BOOLEAN_BITFIELD(knownToHaveNoOverflow, KnownToHaveNoOverflow);
355 ADD_BOOLEAN_BITFIELD(hasEllipsisBoxOrHyphen, HasEllipsisBoxOrHyphen); 364 ADD_BOOLEAN_BITFIELD(hasEllipsisBoxOrHyphen, HasEllipsisBoxOrHyphen);
356 // for InlineTextBox 365 // for InlineTextBox
357 ADD_BOOLEAN_BITFIELD(dirOverride, DirOverride); 366 ADD_BOOLEAN_BITFIELD(dirOverride, DirOverride);
358 ADD_BOOLEAN_BITFIELD(isText, IsText); // Whether or not this object repr esents text with a non-zero height. Includes non-image list markers, text boxes. 367 ADD_BOOLEAN_BITFIELD(isText, IsText); // Whether or not this object repr esents text with a non-zero height. Includes non-image list markers, text boxes.
359 368
360 private: 369 private:
361 mutable unsigned m_determinedIfNextOnLineExists : 1; 370 mutable unsigned m_determinedIfNextOnLineExists : 1;
362 371
363 public: 372 public:
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 452
444 } // namespace blink 453 } // namespace blink
445 454
446 #ifndef NDEBUG 455 #ifndef NDEBUG
447 // Outside the WebCore namespace for ease of invocation from gdb. 456 // Outside the WebCore namespace for ease of invocation from gdb.
448 void showTree(const blink::InlineBox*); 457 void showTree(const blink::InlineBox*);
449 void showLineTree(const blink::InlineBox*); 458 void showLineTree(const blink::InlineBox*);
450 #endif 459 #endif
451 460
452 #endif // InlineBox_h 461 #endif // InlineBox_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutListItem.cpp ('k') | third_party/WebKit/Source/core/layout/line/InlineFlowBox.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698