Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: content/public/common/sandboxed_process_launcher_delegate.h

Issue 1415483008: Get rid of SandboxedProcessLauncherDelegate::PreSandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove curly braces Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/sandboxed_process_launcher_delegate.h
diff --git a/content/public/common/sandboxed_process_launcher_delegate.h b/content/public/common/sandboxed_process_launcher_delegate.h
index 05acf5a6eefbed8baabbc24af41e445ae5a15222..39e2cc88d263dd3fc7e3ce2930190cc3de4bcd4c 100644
--- a/content/public/common/sandboxed_process_launcher_delegate.h
+++ b/content/public/common/sandboxed_process_launcher_delegate.h
@@ -39,16 +39,12 @@ class CONTENT_EXPORT SandboxedProcessLauncherDelegate {
// (i.e. through base::LaunchProcess directly).
virtual bool ShouldSandbox();
- // Called before the default sandbox is applied. If the default policy is too
- // restrictive, the caller should set |disable_default_policy| to true and
- // apply their policy in PreSpawnTarget. |exposed_dir| is used to allow a
- //directory through the sandbox.
- virtual void PreSandbox(bool* disable_default_policy,
- base::FilePath* exposed_dir) {}
-
- // Called right before spawning the process.
- virtual void PreSpawnTarget(sandbox::TargetPolicy* policy,
- bool* success) {}
+ // Whether to disable the default policy specified in
+ // AddPolicyForSandboxedProcess.
+ virtual bool DisableDefaultPolicy();
+
+ // Called right before spawning the process. Returns false on failure.
+ virtual bool PreSpawnTarget(sandbox::TargetPolicy* policy);
// Called right after the process is launched, but before its thread is run.
virtual void PostSpawnTarget(base::ProcessHandle process) {}
« no previous file with comments | « content/public/browser/content_browser_client.cc ('k') | content/public/common/sandboxed_process_launcher_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698