chrome/service/service_utility_process_host.cc - Issue 1415483008: Get rid of SandboxedProcessLauncherDelegate::PreSandbox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_utility_process_host.cc

Issue 1415483008: Get rid of SandboxedProcessLauncherDelegate::PreSandbox. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove curly braces Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/service/service_utility_process_host.cc

diff --git a/chrome/service/service_utility_process_host.cc b/chrome/service/service_utility_process_host.cc

index fbdf202a436d80065bec9550f56270c62ad055c4..36392aa413fb20696c59c04d115d989dca979a83 100644

--- a/chrome/service/service_utility_process_host.cc

+++ b/chrome/service/service_utility_process_host.cc

@@ -26,7 +26,8 @@

#include "content/public/common/sandboxed_process_launcher_delegate.h"

#include "ipc/ipc_switches.h"

#include "printing/emf_win.h"

-#include "sandbox/win/src/sandbox_policy_base.h"

+#include "sandbox/win/src/sandbox_policy.h"

+#include "sandbox/win/src/sandbox_types.h"

#include "ui/base/ui_base_switches.h"

namespace {

@@ -61,10 +62,10 @@ class ServiceSandboxedProcessLauncherDelegate

public:

ServiceSandboxedProcessLauncherDelegate() {}

- void PreSpawnTarget(sandbox::TargetPolicy* policy, bool* success) override {

+ bool PreSpawnTarget(sandbox::TargetPolicy* policy) override {

// Service process may run as windows service and it fails to create a

// window station.

- policy->SetAlternateDesktop(false);

+ return policy->SetAlternateDesktop(false) == sandbox::SBOX_ALL_OK;

}

private:

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | components/nacl/broker/nacl_broker_listener.h » ('j') | no next file with comments »