Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1415463019: Make Dartium JS interop implementation more robust in the presence of JS paths that touch dart:html… (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
Alan Knight, terry
CC:
reviews_dartlang.org, goderbauer
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Dartium JS interop implementation more robust in the presence of JS paths that touch dart:html types. Note that the dart2js implementation was already robust in the presence of dart:html types. BUG= R=alanknight@google.com Committed: https://github.com/dart-lang/sdk/commit/6bfbb93d72af3c4b1ab882994d32647725e8691d

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -12 lines) Patch
M sdk/lib/js/dartium/js_dartium.dart View 9 chunks +39 lines, -12 lines 0 comments Download
M tests/html/js_typed_interop_test.dart View 3 chunks +23 lines, -0 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Jacob
See issue https://github.com/dart-lang/sdk/issues/24817
5 years, 1 month ago (2015-11-04 04:21:31 UTC) #2
Alan Knight
lgtm https://codereview.chromium.org/1415463019/diff/1/tests/html/js_typed_interop_test.dart File tests/html/js_typed_interop_test.dart (right): https://codereview.chromium.org/1415463019/diff/1/tests/html/js_typed_interop_test.dart#newcode395 tests/html/js_typed_interop_test.dart:395: test('js path contains html types', () { nit: ...
5 years, 1 month ago (2015-11-04 18:44:14 UTC) #3
Jacob
https://codereview.chromium.org/1415463019/diff/1/tests/html/js_typed_interop_test.dart File tests/html/js_typed_interop_test.dart (right): https://codereview.chromium.org/1415463019/diff/1/tests/html/js_typed_interop_test.dart#newcode395 tests/html/js_typed_interop_test.dart:395: test('js path contains html types', () { On 2015/11/04 ...
5 years, 1 month ago (2015-11-04 19:01:30 UTC) #4
Jacob
5 years, 1 month ago (2015-11-04 23:47:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6bfbb93d72af3c4b1ab882994d32647725e8691d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698