Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: src/builtins.cc

Issue 1415463002: Stack buffer for builtin code generation too small in some cases. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index b672185792c417a75f311c7ea6b35d880f91f6a4..2f8cfc2c17a214e367b02baeb55e0617df1a7517 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -11,6 +11,7 @@
#include "src/bootstrapper.h"
#include "src/elements.h"
#include "src/frames-inl.h"
+#include "src/full-codegen/full-codegen.h"
ulan 2015/10/21 12:26:51 Let's not add dependency on full-codegen for built
#include "src/gdb-jit.h"
#include "src/ic/handler-compiler.h"
#include "src/ic/ic.h"
@@ -2095,7 +2096,8 @@ void Builtins::SetUp(Isolate* isolate, bool create_heap_objects) {
// We can generate a lot of debug code on Arm64.
const size_t buffer_size = 32*KB;
#else
- const size_t buffer_size = 8*KB;
+ const size_t buffer_size =
+ ((8 * FullCodeGenerator::kCodeSizeMultiplier) / 100) * KB;
#endif
union { int force_alignment; byte buffer[buffer_size]; } u;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698