Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: util/win/registration_protocol_win.cc

Issue 1415453012: win: Log the error code if CreateFile() fails during registration (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: TransactNamedPipe() like LoggingReadFile() Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/win/registration_protocol_win.cc
diff --git a/util/win/registration_protocol_win.cc b/util/win/registration_protocol_win.cc
index 3e0fdf213985a4bc81ae295bd3377140463045da..0f1062c786be0b7e4618132e5bd1b6ef1fa90f89 100644
--- a/util/win/registration_protocol_win.cc
+++ b/util/win/registration_protocol_win.cc
@@ -59,13 +59,14 @@ bool SendToCrashHandlerServer(const base::string16& pipe_name,
return false;
}
if (bytes_read != sizeof(*response)) {
- LOG(ERROR) << "TransactNamedPipe read incorrect number of bytes";
+ LOG(ERROR) << "TransactNamedPipe: expected " << sizeof(*response)
+ << ", observed " << bytes_read;
return false;
}
return true;
}
- LOG(ERROR) << "failed to connect after retrying";
+ PLOG(ERROR) << "CreateFile";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698