Issue 1415453012: win: Log the error code if CreateFile() fails during registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1415453012: win: Log the error code if CreateFile() fails during registration (Closed)

Created:
5 years, 1 month ago by Mark Mentovai

Modified:
5 years, 1 month ago

Reviewers:
scottmg

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

win: Log the error code if CreateFile() fails during registration BUG=crashpad:75 Obsoleted by https://codereview.chromium.org/1409693011/, abandoned.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	util/win/registration_protocol_win.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (2 generated)

Mark Mentovai

This doesn’t fix the bug, but when we are retrying and give up, we should ...

5 years, 1 month ago (2015-11-06 22:54:57 UTC) #2

Mark Mentovai

5 years, 1 month ago (2015-11-06 23:58:14 UTC) #4

Message was sent while issue was closed.

Closed now. https://codereview.chromium.org/1409693011/ covered this and more.