Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1415423002: XFA: Sync build and documentation differences with master (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Sync build and documentation differences with master. This Cl syncs the AUTHORS, and README.md and build scripts in XFA to match master where possible. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/bc6c6723c37772b02de9e6e43fa0fd9439874905

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -173 lines) Patch
M AUTHORS View 2 chunks +3 lines, -1 line 0 comments Download
M BUILD.gn View 22 chunks +87 lines, -30 lines 2 comments Download
D README View 1 chunk +0 lines, -1 line 0 comments Download
A + README.md View 3 chunks +5 lines, -5 lines 0 comments Download
D docs/build.md View 1 chunk +0 lines, -134 lines 0 comments Download
M pdfium.gni View 1 chunk +0 lines, -1 line 0 comments Download
M pdfium.gyp View 2 chunks +7 lines, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
dsinclair
PTAL.
5 years, 2 months ago (2015-10-22 18:29:15 UTC) #3
Tom Sepez
LGTM with nits. The nits are to be changed in both branches, though :( https://codereview.chromium.org/1415423002/diff/1/BUILD.gn ...
5 years, 2 months ago (2015-10-22 18:46:14 UTC) #4
dsinclair
Committed patchset #1 (id:1) manually as bc6c6723c37772b02de9e6e43fa0fd9439874905 (presubmit successful).
5 years, 2 months ago (2015-10-22 18:59:02 UTC) #5
Lei Zhang
https://codereview.chromium.org/1415423002/diff/1/pdfium.gyp File pdfium.gyp (right): https://codereview.chromium.org/1415423002/diff/1/pdfium.gyp#newcode779 pdfium.gyp:779: 'testing/fx_string_testhelpers.h', eh? .cpp before .h.
5 years, 2 months ago (2015-10-22 20:42:31 UTC) #6
dsinclair
5 years, 2 months ago (2015-10-22 20:44:49 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/1415423002/diff/1/pdfium.gyp
File pdfium.gyp (right):

https://codereview.chromium.org/1415423002/diff/1/pdfium.gyp#newcode779
pdfium.gyp:779: 'testing/fx_string_testhelpers.h',
On 2015/10/22 20:42:30, Lei Zhang wrote:
> eh? .cpp before .h.

I made this match master, looks like master is also wrong in this regard.

Powered by Google App Engine
This is Rietveld 408576698