Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1415413015: Cleanup header inclusions on Android media player implementation. (Closed)

Created:
5 years, 1 month ago by msu.koo
Modified:
5 years, 1 month ago
Reviewers:
qinmin, dcheng
CC:
avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup header inclusions on Android media player implementation. This patch is to cleanup header inclusion for - media_player_message_android.h - renderer_demuxer_android.cc - webmediaplayer_android.h BUG=NONE Committed: https://crrev.com/717d3dfc94e269fb22796be96aa60adfcec9c18f Cr-Commit-Position: refs/heads/master@{#359045}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/common/media/media_player_messages_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/android/renderer_demuxer_android.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
msu.koo
Hello. I found some header inclusions which require cleanup, and this patch is for it. ...
5 years, 1 month ago (2015-11-10 02:27:07 UTC) #2
dcheng
rs lgtm for #include removal in content/common/media/media_player_messages_android.h
5 years, 1 month ago (2015-11-10 02:57:28 UTC) #3
qinmin
lgtm
5 years, 1 month ago (2015-11-10 18:47:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413015/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413015/1
5 years, 1 month ago (2015-11-11 01:45:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-11 04:10:51 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 04:11:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/717d3dfc94e269fb22796be96aa60adfcec9c18f
Cr-Commit-Position: refs/heads/master@{#359045}

Powered by Google App Engine
This is Rietveld 408576698