Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1415413012: Fix flaky async test. (Closed)

Created:
5 years, 1 month ago by Florian Schneider
Modified:
5 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix flaky async test. Replacing > with >= since finishing in 10 to 11 ms is to be expected. BUG=dartbug.com/24788 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/eb3186b7bd35c94a35b094c6684de48c0abb94dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/lib/async/stream_periodic3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
5 years, 1 month ago (2015-11-02 19:16:33 UTC) #2
Florian Schneider
Ping.
5 years, 1 month ago (2015-11-03 21:40:59 UTC) #3
floitsch
LGTM!
5 years, 1 month ago (2015-11-03 22:08:07 UTC) #4
Florian Schneider
5 years, 1 month ago (2015-11-03 22:30:05 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb3186b7bd35c94a35b094c6684de48c0abb94dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698