Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1415413009: Use a circular profile icon in "open link as user" context menu (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a circular profile icon in "open link as user" context menu BUG=103073 R=bauerb@chromium.org Committed: https://crrev.com/c728506417575c5ff9bdcac97b2b6771a71d0506 Cr-Commit-Position: refs/heads/master@{#356269}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-10-27 08:31:14 UTC) #1
jochen (gone - plz use gerrit)
because UI review said so ptal
5 years, 1 month ago (2015-10-27 08:31:35 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/1415413009/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc File chrome/browser/renderer_context_menu/render_view_context_menu.cc (right): https://codereview.chromium.org/1415413009/diff/1/chrome/browser/renderer_context_menu/render_view_context_menu.cc#newcode393 chrome/browser/renderer_context_menu/render_view_context_menu.cc:393: gfx::Path circular_mask; Add a comment that explains what ...
5 years, 1 month ago (2015-10-27 09:44:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413009/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413009/20001
5 years, 1 month ago (2015-10-27 10:31:58 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-27 11:35:45 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 11:36:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c728506417575c5ff9bdcac97b2b6771a71d0506
Cr-Commit-Position: refs/heads/master@{#356269}

Powered by Google App Engine
This is Rietveld 408576698