Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 1415413007: Revert of Fix up the clip mask manager's creation of paths (w.r.t. volatility) (Closed)

Created:
5 years, 1 month ago by robertphillips
Modified:
5 years, 1 month ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@mdb-simplify-cmm
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix up the clip mask manager's creation of paths (w.r.t. volatility) (patchset #1 id:1 of https://codereview.chromium.org/1419403002/ ) Reason for revert: Logic may be incorrect Original issue's description: > Fix up the clip mask manager's creation of paths (w.r.t. volatility) > > I don't expect this to make any difference (perf-wise) but it seems more correct. > > This CL relies on https://codereview.chromium.org/1421533007/ (Fix ClipMaskManager's SW-fallback logic) > > Committed: https://skia.googlesource.com/skia/+/953fe3139fa60ce56abcfa45a3647d924e637083 TBR=jvanverth@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/ee7d516d4bc13a0e449ccdc55a3858845516b864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/core/SkClipStack.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Fix up the clip mask manager's creation of paths (w.r.t. volatility)
5 years, 1 month ago (2015-10-26 21:11:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415413007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415413007/1
5 years, 1 month ago (2015-10-26 21:11:10 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 21:11:18 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee7d516d4bc13a0e449ccdc55a3858845516b864

Powered by Google App Engine
This is Rietveld 408576698