Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: tools/telemetry/catapult_base/dependency_manager/dependency_manager.py

Issue 1415413005: Revert of [Android] Add a configurable environment for devil/. (RELAND) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/java_apk.gypi ('k') | tools/telemetry/telemetry/internal/util/binary_manager.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/catapult_base/dependency_manager/dependency_manager.py
diff --git a/tools/telemetry/catapult_base/dependency_manager/dependency_manager.py b/tools/telemetry/catapult_base/dependency_manager/dependency_manager.py
index e925d1aa83a845fac813398d6f8c21b8f398b6a9..9e1de84fcfe70e92f847e353ea4aa405e467fba5 100644
--- a/tools/telemetry/catapult_base/dependency_manager/dependency_manager.py
+++ b/tools/telemetry/catapult_base/dependency_manager/dependency_manager.py
@@ -89,6 +89,8 @@
"""
dependency_info = self._GetDependencyInfo(dependency, platform)
if not dependency_info:
+ logging.error(
+ 'The dependency_manager was not initialized with the dependency.')
if not try_support_binaries:
raise exceptions.NoPathFoundError(dependency, platform)
# TODO(aiolos): Remove the support_binaries call and always raise
@@ -139,6 +141,8 @@
# system.
dependency_info = self._GetDependencyInfo(dependency, platform)
if not dependency_info:
+ logging.error(
+ 'The dependency_manager was not initialized with the dependency.')
if not try_support_binaries:
raise exceptions.NoPathFoundError(dependency, platform)
return support_binaries.FindLocallyBuiltPath(dependency)
« no previous file with comments | « build/java_apk.gypi ('k') | tools/telemetry/telemetry/internal/util/binary_manager.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698