GN bootstrap fixes:

GN bootstrap fixes:

- add missing base/threading/thread.cc to compile targets
- add --gn-gen-args for passing custom --args to gn gen
  (when building GN with itself)
- allow overriding use_cups

BUG=551343
Committed: https://crrev.com/ae483ee1eccc94ab232a6f6e91874d852edd0942
Cr-Commit-Position: refs/heads/master@{#358090}

[Paweł Hajdan Jr., 2015-11-04 14:41:19]

phajdan.jr@chromium.org changed reviewers:
+ dpranke@chromium.org, phajdan.jr@chromium.org

[tfarina, 2015-11-04 15:04:31]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-11-04 15:04:31]

lgtm

https://codereview.chromium.org/1415343008/diff/1/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1415343008/diff/1/build/config/features.gni#n...
build/config/features.gni:119: use_cups = (is_desktop_linux || is_mac) &&
!is_chromecast
was this required for the bootstrap fixes? If not, I would suggest doing it in a
separate CL.

[Paweł Hajdan Jr., 2015-11-04 16:55:55]

https://codereview.chromium.org/1415343008/diff/1/build/config/features.gni
File build/config/features.gni (right):

https://codereview.chromium.org/1415343008/diff/1/build/config/features.gni#n...
build/config/features.gni:119: use_cups = (is_desktop_linux || is_mac) &&
!is_chromecast
On 2015/11/04 at 15:04:31, tfarina wrote:
> was this required for the bootstrap fixes? If not, I would suggest doing it in
a separate CL.

Yes, this makes bootstrap possible in an environment where cups is unavailable.

[Paweł Hajdan Jr., 2015-11-04 17:01:37]

The CQ bit was checked by phajdan.jr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-04 17:04:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415343008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415343008/1

[commit-bot: I haz the power, 2015-11-04 17:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 17:30:05]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2015-11-05 17:39:04]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2015-11-05 17:39:05]

lgtm

[Paweł Hajdan Jr., 2015-11-05 17:41:06]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2015-11-05 17:42:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1415343008/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1415343008/1

[commit-bot: I haz the power, 2015-11-05 18:20:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-11-05 18:21:11]

Patchset 1 (id:??) landed as
https://crrev.com/ae483ee1eccc94ab232a6f6e91874d852edd0942
Cr-Commit-Position: refs/heads/master@{#358090}