Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: chrome/browser/resources/options/password_manager_list.js

Issue 1415333009: [Password Manager] Recovers implied focus traverse on chrome://settings/passwords (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_550270
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/password_manager_list.js
diff --git a/chrome/browser/resources/options/password_manager_list.js b/chrome/browser/resources/options/password_manager_list.js
index c4af28d4ba7eec8d0731da282629d46338877f75..3ad7a6421bb9616937aae9fb37d0c84dd3a628ad 100644
--- a/chrome/browser/resources/options/password_manager_list.js
+++ b/chrome/browser/resources/options/password_manager_list.js
@@ -75,11 +75,13 @@ cr.define('options.passwordManager', function() {
'title', getTitleForPasswordOrigin(this.url, this.isUrlSecure));
var urlLink = this.ownerDocument.createElement('a');
urlLink.href = this.url;
+ urlLink.setAttribute('target', '_blank');
urlLink.textContent = this.shownUrl.split('').reverse().join('');
urlDiv.appendChild(urlLink);
urlDiv.style.backgroundImage = getFaviconImageSet(
'origin/' + this.url, 16);
this.contentElement.appendChild(urlDiv);
+ this.urlField = urlLink;
Evan Stade 2015/11/04 16:44:42 nit: s/urlField/urlLink
kolos1 2015/11/04 16:52:43 Done.
// The stored username.
var usernameDiv = this.ownerDocument.createElement('div');
@@ -172,7 +174,10 @@ cr.define('options.passwordManager', function() {
*/
setFocusable_: function(focusable) {
var tabIndex = focusable ? 0 : -1;
- this.passwordField.tabIndex = this.closeButtonElement.tabIndex = tabIndex;
+ this.urlField.tabIndex = tabIndex;
+ this.usernameField.tabIndex = tabIndex;
+ this.passwordField.tabIndex = tabIndex;
+ this.closeButtonElement.tabIndex = tabIndex;
},
/**
@@ -323,9 +328,11 @@ cr.define('options.passwordManager', function() {
var urlLink = this.ownerDocument.createElement('a');
urlLink.href = this.url;
urlLink.textContent = this.shownUrl.split('').reverse().join('');
+ urlLink.setAttribute('target', '_blank');
urlDiv.appendChild(urlLink);
urlDiv.style.backgroundImage = getFaviconImageSet(
'origin/' + this.url, 16);
+ urlLink.tabIndex = -1;
this.contentElement.appendChild(urlDiv);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698