[Password Manager] Recovers implied focus traverse on chrome://settings/passwords

chrome/browser/resources/options/password_manager_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options.passwordManager', function() {
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var List = cr.ui.List;
 
@@ skipping 57 matching lines @@
     decorate: function() {
       DeletableItem.prototype.decorate.call(this);
 
       // The URL of the site.
       var urlDiv = this.ownerDocument.createElement('div');
       urlDiv.className = 'favicon-cell left-elided-url url';
       urlDiv.setAttribute(
           'title', getTitleForPasswordOrigin(this.url, this.isUrlSecure));
       var urlLink = this.ownerDocument.createElement('a');
       urlLink.href = this.url;
+      urlLink.setAttribute('target', '_blank');
       urlLink.textContent = this.shownUrl.split('').reverse().join('');
       urlDiv.appendChild(urlLink);
       urlDiv.style.backgroundImage = getFaviconImageSet(
           'origin/' + this.url, 16);
       this.contentElement.appendChild(urlDiv);
+      this.urlField = urlLink;

[Evan Stade, 2015/11/04 16:44:42]

nit: s/urlField/urlLink

[kolos1, 2015/11/04 16:52:43]

Done.

 
       // The stored username.
       var usernameDiv = this.ownerDocument.createElement('div');
       usernameDiv.className = 'name';
       usernameDiv.title = this.username;
       this.contentElement.appendChild(usernameDiv);
       var usernameInput = this.ownerDocument.createElement('input');
       usernameInput.type = 'text';
       usernameInput.className = 'inactive-item';
       usernameInput.readOnly = true;
@@ skipping 72 matching lines @@
       }
     },
 
     /**
      * Set the focusability of this row.
      * @param {boolean} focusable
      * @private
      */
     setFocusable_: function(focusable) {
       var tabIndex = focusable ? 0 : -1;
-      this.passwordField.tabIndex = this.closeButtonElement.tabIndex = tabIndex;
+      this.urlField.tabIndex = tabIndex;
+      this.usernameField.tabIndex = tabIndex;
+      this.passwordField.tabIndex = tabIndex;
+      this.closeButtonElement.tabIndex = tabIndex;
     },
 
     /**
      * Reveals the plain text password of this entry.
      */
     showPassword: function(password) {
       this.passwordField.value = password;
       this.passwordField.type = 'text';
 
       var button = this.passwordShowButton;
@@ skipping 130 matching lines @@
       // The URL of the site.
       var urlDiv = this.ownerDocument.createElement('div');
       urlDiv.className = 'url';
       urlDiv.classList.add('favicon-cell');
       urlDiv.classList.add('left-elided-url');
       urlDiv.setAttribute(
           'title', getTitleForPasswordOrigin(this.url, this.isUrlSecure));
       var urlLink = this.ownerDocument.createElement('a');
       urlLink.href = this.url;
       urlLink.textContent = this.shownUrl.split('').reverse().join('');
+      urlLink.setAttribute('target', '_blank');
       urlDiv.appendChild(urlLink);
       urlDiv.style.backgroundImage = getFaviconImageSet(
           'origin/' + this.url, 16);
+      urlLink.tabIndex = -1;
       this.contentElement.appendChild(urlDiv);
     },
 
     /**
      * Get the url for the entry.
      * @type {string}
      */
     get url() {
       return this.dataItem[ORIGIN_FIELD];
     },
@@ skipping 140 matching lines @@
     PasswordExceptionsList: PasswordExceptionsList,
     ORIGIN_FIELD: ORIGIN_FIELD,
     SHOWN_URL_FIELD: SHOWN_URL_FIELD,
     IS_SECURE_FIELD: IS_SECURE_FIELD,
     USERNAME_FIELD: USERNAME_FIELD,
     PASSWORD_FIELD: PASSWORD_FIELD,
     FEDERATION_FIELD: FEDERATION_FIELD,
     ORIGINAL_INDEX_FIELD: ORIGINAL_INDEX_FIELD
   };
 });