chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc - Issue 1415333002: [Media Router] Add experiment control logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

Issue 1415333002: [Media Router] Add experiment control logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed msw@'s comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/media_router/media_router_test.h » ('j') | chrome/browser/ui/webui/media_router/media_router_test.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

index 7362141a5aa5f0423f9fd7becd4048f677b1c9eb..1c40511f5efc38dedc661a8fadc6cf99ffe829f8 100644

--- a/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl_browsertest.cc

@@ -25,10 +25,8 @@ class MediaRouterDialogControllerBrowserTest : public InProcessBrowserTest {

MediaRouterDialogControllerBrowserTest()

: dialog_controller_(nullptr),

initiator_(nullptr),

- media_router_dialog_(nullptr) {

- base::CommandLine::ForCurrentProcess()->AppendSwitch(

- switches::kEnableMediaRouter);

- }

+ media_router_dialog_(nullptr),

+ feature_override_(FeatureSwitch::media_router(), true) {}

~MediaRouterDialogControllerBrowserTest() override {}

protected:

@@ -55,6 +53,7 @@ class MediaRouterDialogControllerBrowserTest : public InProcessBrowserTest {

WebContents* media_router_dialog_;

private:

+ extensions::FeatureSwitch::ScopedOverride feature_override_;

DISALLOW_COPY_AND_ASSIGN(MediaRouterDialogControllerBrowserTest);

};