Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6384)

Unified Diff: chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc

Issue 1415333002: [Media Router] Add experiment control logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
diff --git a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
index cdde653df7a195b7c119a0dc811fb29a3eab1c9f..7331406ae934a671d8e6d90d09c4bc6246995cc8 100644
--- a/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
+++ b/chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
@@ -6,13 +6,16 @@
#include "base/command_line.h"
#include "base/lazy_instance.h"
+#include "chrome/browser/media/router/media_router_feature.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/toolbar/media_router_action.h"
#include "chrome/browser/ui/toolbar/toolbar_action_view_controller.h"
-#include "chrome/common/chrome_switches.h"
#include "extensions/common/feature_switch.h"
+#if defined(ENABLE_MEDIA_ROUTER)
+#include "chrome/browser/ui/toolbar/media_router_action.h"
+#endif
+
namespace {
ComponentToolbarActionsFactory* testing_factory_ = nullptr;
@@ -43,7 +46,7 @@ std::set<std::string> ComponentToolbarActionsFactory::GetComponentIds(
if (!extensions::FeatureSwitch::extension_action_redesign()->IsEnabled())
return component_ids;
- if (switches::MediaRouterEnabled() && !profile->IsOffTheRecord())
+ if (media_router::MediaRouterEnabled() && !profile->IsOffTheRecord())
component_ids.insert(kMediaRouterActionId);
return component_ids;
@@ -64,9 +67,11 @@ ComponentToolbarActionsFactory::GetComponentToolbarActionForId(
// (since each will have an action in the toolbar or overflow menu), this
// should be okay. If this changes, we should rethink this design to have,
// e.g., RegisterChromeAction().
+#if defined(ENABLE_MEDIA_ROUTER)
if (id == kMediaRouterActionId)
return scoped_ptr<ToolbarActionViewController>(
new MediaRouterAction(browser));
+#endif // defined(ENABLE_MEDIA_ROUTER)
NOTREACHED();
return scoped_ptr<ToolbarActionViewController>();
« no previous file with comments | « chrome/browser/ui/toolbar/app_menu_model.cc ('k') | chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698