Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6484)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1415333002: [Media Router] Add experiment control logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 7330cf235ae7ca0d0053819d1eb4418270005e12..b3f5451ef3fa20cd328f209b8809644058136221 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -30,8 +30,7 @@
#include "chrome/browser/download/download_stats.h"
#include "chrome/browser/extensions/devtools_util.h"
#include "chrome/browser/extensions/extension_service.h"
-#include "chrome/browser/media/router/media_router_dialog_controller.h"
-#include "chrome/browser/media/router/media_router_metrics.h"
+#include "chrome/browser/media/router/media_router_feature.h"
#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
#include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
@@ -133,6 +132,11 @@
#include "chrome/browser/chromeos/profiles/profile_helper.h"
#endif
+#if defined(ENABLE_MEDIA_ROUTER)
+#include "chrome/browser/media/router/media_router_dialog_controller.h"
+#include "chrome/browser/media/router/media_router_metrics.h"
+#endif
+
using base::UserMetricsAction;
using blink::WebContextMenuData;
using blink::WebMediaPlayerAction;
@@ -1057,9 +1061,11 @@ void RenderViewContextMenu::AppendPrintItem() {
}
void RenderViewContextMenu::AppendMediaRouterItem() {
- if (switches::MediaRouterEnabled() && !browser_context_->IsOffTheRecord())
+ if (media_router::MediaRouterEnabled() &&
+ !browser_context_->IsOffTheRecord()) {
menu_model_.AddItemWithStringId(IDC_ROUTE_MEDIA,
IDS_MEDIA_ROUTER_MENU_ITEM_TITLE);
+ }
}
void RenderViewContextMenu::AppendRotationItems() {
@@ -1524,7 +1530,7 @@ bool RenderViewContextMenu::IsCommandIdEnabled(int id) const {
return true;
case IDC_ROUTE_MEDIA: {
- DCHECK(switches::MediaRouterEnabled());
+ DCHECK(media_router::MediaRouterEnabled());
// Disable the command if there is an active modal dialog.
Browser* browser =
@@ -1842,8 +1848,8 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
}
case IDC_ROUTE_MEDIA: {
- DCHECK(switches::MediaRouterEnabled());
-
+ DCHECK(media_router::MediaRouterEnabled());
+#if defined(ENABLE_MEDIA_ROUTER)
Browser* browser =
chrome::FindBrowserWithWebContents(source_web_contents_);
DCHECK(browser && !browser->profile()->IsOffTheRecord());
@@ -1851,15 +1857,13 @@ void RenderViewContextMenu::ExecuteCommand(int id, int event_flags) {
media_router::MediaRouterDialogController* dialog_controller =
media_router::MediaRouterDialogController::GetOrCreateForWebContents(
source_web_contents_);
-
if (!dialog_controller)
return;
dialog_controller->ShowMediaRouterDialog();
-
media_router::MediaRouterMetrics::RecordMediaRouterDialogOrigin(
media_router::CONTEXTUAL_MENU);
-
+#endif // defined(ENABLE_MEDIA_ROUTER)
break;
}

Powered by Google App Engine
This is Rietveld 408576698