Issue 141533004: Moving logic to AstNode to determine how many type cells are required.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 141533004: Moving logic to AstNode to determine how many type cells are required. (Closed)

Created:
6 years, 11 months ago by mvstanton

Modified:
6 years, 11 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Moving logic to AstNode to determine how many type cells are required. With this change, we'll be able to discover how many type cells we need at parse time, enabling future optimizations. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18668

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -25 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 2	4 chunks	+9 lines, -6 lines	0 comments	Download
M	src/ast.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/ast.cc	View	1	1 chunk	+17 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1	4 chunks	+9 lines, -6 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 2	4 chunks	+9 lines, -6 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 2	4 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Benedikt, here is a refactoring that moves us closer to determining the number of ...

6 years, 11 months ago (2014-01-17 12:24:30 UTC) #1

mvstanton

6 years, 11 months ago (2014-01-17 14:08:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r18668 (presubmit successful).