Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 141533003: Minor bugfix in building inlined Array: bad argument to JSArrayBuilder. (Closed)

Created:
6 years, 11 months ago by mvstanton
Modified:
6 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Minor bugfix in building inlined Array: bad argument to JSArrayBuilder. An HConstant pointing to a Cell rather than an AllocationSite was passed. The argument wasn't used because of fortuitous flags. An assert was added to protect the argument. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M src/hydrogen.cc View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Benedikt, I noticed a small bug, can you take a look? thx, --Michael
6 years, 11 months ago (2014-01-17 11:40:27 UTC) #1
Benedikt Meurer
LGTM
6 years, 11 months ago (2014-01-17 11:41:06 UTC) #2
mvstanton
6 years, 11 months ago (2014-01-17 12:19:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18666 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698